search

Ballsdex-Team / BallsDex-DiscordBot

Collect and exchange countryballs on Discord
Other
95 stars 158 forks source link

[settings] move packages to settings #472

Open Dotsian opened 3 days ago

Dotsian commented 3 days ago

This change makes it easier for self-hosted owners to add custom packages (without having to modify the bot.py file).

flaree commented 3 days ago

While this is a great idea, I foresee issues in the future should we add more cogs to the base bot as it won't be propagated to everyone's configs downstream

laggron42 commented 3 days ago

Haha you got forward of me, this is actually a change I've planned to do but a little differently, by using full importable paths instead (like ballsdex.packages.trade). This would allow 3rd party cogs to exist in their own pip-installable repositories, thus allowing users to install additional cogs without having to manually drop files or edit code.

Do you think you could change the PR to reflect that? You'd also need to remove the prepended path here.

While this is a great idea, I foresee issues in the future should we add more cogs to the base bot as it won't be propagated to everyone's configs downstream

I can still think of ways to dynamically extend the list of cogs after this change. Not trivial, but doable, and the benefits are really nice.

laggron42 commented 2 days ago

Thanks for the change, I'll test it as soon as possible but it already looks good on a first glance