search

Banno / asdf-jsonnet

MIT License
2 stars 1 forks source link

Support go jsonnet too? #1

Open ghostsquad opened 4 years ago

ghostsquad commented 4 years ago

Would you be interested in supporting go-jsonnet?

craigfurman commented 4 years ago

I wrote an asdf plugin for go-jsonnet a while back: https://gitlab.com/craigfurman/asdf-go-jsonnet

Now that I think about it, one plugin could represent both implementations of jsonnet using different version strings (0.17.0 and go-0.17.0, for example). This one is already in https://github.com/asdf-vm/asdf-plugins, so I guess it makes sense to do it here. I'd be happy to PR go-jsonnet support if the maintainers are interested?

ghostsquad commented 4 years ago

@craigfurman yep I use your plugin currently. It would be very nice to ensure a specific implementation is used. I've made some contributions to the Go version that makes it much faster in some cases that the original.

craigfurman commented 4 years ago

That's great, I'm a big fan of go-jsonnet's speed. @nikolay you've got every commit in this repo, but I see it's been a while. Are you interested in maintaining support for go-jsonnet versions in this repo? If not, that's fine, and I'll likely look into PR'ing https://gitlab.com/craigfurman/asdf-go-jsonnet into https://github.com/asdf-vm/asdf-plugins.

nikolay commented 4 years ago

@craigfurman Yeah, it's been a while. And a while since I last used Jsonnet. Are they now equivalent as back then they weren't?

ghostsquad commented 4 years ago

Go-jsonnet is the future, even the maintainers want to encourage more adoption of it over the C++ version.