Barnard-PL-Labs / SequencerLiveCoding

Live Coding for the Novation Circuit
19 stars 5 forks source link

replace the in-code timeout param with the AWS Lambda timeout config #25

Open santolucito opened 2 years ago

santolucito commented 2 years ago

https://github.com/Barnard-PL-Labs/SequencerLiveCoding/blob/d5f087c9201e674e3b673fb4d9170cfe558cf907/serverless/index.js#L19

the timeout in AWS is much easier to reconfigure than needing to upload a new lambda everytime.

Need to check what happens when a lambda timeouts in https://github.com/Barnard-PL-Labs/SequencerLiveCoding/blob/d5f087c9201e674e3b673fb4d9170cfe558cf907/serverSide/callServerlessCVC5.js#L14

does it thrown an exception, or do we need to more carefully handle whatever value we get back when a Lambda times out

takumh commented 2 years ago

TimeFreq

based on this frequency table generated from user data, the optimal timeout is 3 seconds because maximum frequency is recorded between 0 and 3 seconds.