BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.
GNU General Public License v3.0
5.27k stars 237 forks source link

[BUG]: The HDR control should not be displayed, for the screen does not support HDR itself #667

Closed henry-ji closed 1 year ago

henry-ji commented 1 year ago

Version

2.11.2

OS

Windows 11 OS build 25336

Device

Legion R9000X 2021R (aka Legion S7 15ACH6 outside China)

BIOS version

HACN40WW

What's wrong?

The HDR control is displayed

How to reproduce the bug?

it just appears on the frontpage

What is the behavior that you expected?

The HDR control should not be displayed, for the screen does not support HDR itself

Logs

log_2023_04_11_14_03_46.txt

Do you have Lenovo software installed?

Did you disable any Lenovo software using Lenovo Legion Toolkit?

Additional information

No response

henry-ji commented 1 year ago
image

P.S. I've also noticed that it will turn on/off the "Automatically manage color for apps" automatically when I turn on/off the HDR

The Chinese on the right of the picture refers to Settings > System > Display > Advanced display > Automatically manage color for apps I'm really sorry if the Chinese caused difficulty to understand, but it's really annoying to switch my OS to English for I have to log it out.

BartoszCichecki commented 1 year ago

LLT checks the AdvancedColorSupported and AdvancedColorEnabled flags via Windows API and as per Windows documentation that is the correct way of checking for HDR support.

If your screen doesn't support HDR, then Windows is falsely reporting that display supports HDR and there is nothing I can do about it.