Baseflow / flutter-geocoding

A Geocoding plugin for Flutter
https://baseflow.com
MIT License
136 stars 71 forks source link

[Bug]: Wrong Versioning #216

Closed luis901101 closed 6 months ago

luis901101 commented 6 months ago

Please check the following before submitting a new issue.

Please select affected platform(s)

Steps to reproduce

Having geocoding: ^2.2.0, when you run:

flutter pub upgrade
flutter run

Project fails to build.

Expected results

Project should not fail to build as the new version indicates a hot-fix change which must not break builds. The versioning should have been v3.0.0 to indicate devs the possible need to refactor after manually upgrading the version.

Actual results

Project fails to build.

Code sample

With v2.2.0:

List<Placemark> placeMarks =
        await placemarkFromCoordinates(
      latitude,
      longitude,
      localeIdentifier: localeIdentifier,
    )

Now with v2.2.1

if(localeIdentifier != null) {
      await setLocaleIdentifier(localeIdentifier);
    }
    List<Placemark> placeMarks =
        await placemarkFromCoordinates(
      latitude,
      longitude,
    );

Screenshots or video

Screenshots or video demonstration [Upload media here]

Version

2.2.1

Flutter Doctor output

Doctor output ```console [✓] Flutter (Channel stable, 3.19.3, on macOS 14.0 23A344 darwin-arm64, locale en-US) • Flutter version 3.19.3 on channel stable at /Users/user/fvm/versions/3.19.3 • Upstream repository https://github.com/flutter/flutter.git • Framework revision ba39319843 (4 days ago), 2024-03-07 15:22:21 -0600 • Engine revision 2e4ba9c6fb • Dart version 3.3.1 • DevTools version 2.31.1 [✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0) • Android SDK at /Users/user/Android/SDK • Platform android-34, build-tools 34.0.0 • ANDROID_HOME = /Users/user/Android/SDK • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 15.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Build 15C65 • CocoaPods version 1.13.0 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 2023.2) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • android-studio-dir = /Applications/Android Studio.app/ • Java version OpenJDK Runtime Environment (build 17.0.9+0-17.0.9b1087.7-11185874) ```