Baseflow / flutter-geocoding

A Geocoding plugin for Flutter
https://baseflow.com
MIT License
134 stars 69 forks source link

[Feature request]: Older synchronous Android code can be removed #220

Closed lukehutch closed 4 months ago

lukehutch commented 4 months ago

Is there already an issue requesting this feature?

Please select affected platform(s)

Use case

I filed #195 requesting for the newer Android async geocoder API to be supported in API > 33. Thanks for adding that!

However, I noticed that since release 2.0.6 of flutter-geocoding, compileSdkVersion has actually been set to 33 on Android.

As I'm sure you know, there's no going back from API 33 at this point, because all new app store releases (and even app store updates) of Android apps have to at a minimum be built for API 33:

https://apilevels.com/

This means that guarded sections like the following are not needed, and all older Android code (before TIRIMASU) can be removed:

https://github.com/Baseflow/flutter-geocoding/blob/main/geocoding_android/android/src/main/java/com/baseflow/geocoding/Geocoding.java#L58

Proposal

Remove all old code

Specific requirements or considerations

--

Additional information or context

No response

TimHoogstrate commented 4 months ago

Dear @lukehutch,

I think this is not true. Even though the compileSdkVersion is e.g. > 33, the software can still run on a < 33 SDK device.

Kind regards,

lukehutch commented 4 months ago

Got it, thanks for clarifying.