shfmt and shellcheck for a few more files

seefood commented 3 days ago

Description

picked a few completions and plugins at random and cleaned them up with shellcheck and shfmt

How Has This Been Tested?

passed to the CI after pre-commit was happy

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] If my change requires a change to the documentation, I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
[ ] I have added tests to cover my changes, and all the new and existing tests pass.

cornfeedhobo commented 3 days ago

@seefood Would you like some help with reviews? I'm concerned about these failing tests and how much code is getting merged and self-reviewed right now.

seefood commented 2 days ago

@seefood Would you like some help with reviews? I'm concerned about these failing tests and how much code is getting merged and self-reviewed right now.

I would love some. Noah gave me maintainer rights to release some of the pressure, and I merged the easy stuff that was stuck, but most of what remans are the trickier stuff that's got some bitrot, and some of it needs manual merges, while others are maybe no longer relevant.

the issue with BATS complaining about too few tests running - I have no idea why iot happens yet, I have not dived into that yet.

Bash-it / bash-it