Bastian / bStats

bStats collects data for plugin authors. It's free and easy to use!
https://bstats.org/
MIT License
150 stars 33 forks source link

Canary category #42

Open jamierocks opened 7 years ago

jamierocks commented 7 years ago

CanaryMod is admittedly dead is some people's eyes - I prefer hibernating - we've used mcstats for some time now, internally to track users of CanaryMod and by extension NeptuneMod.

bStats has now been around long enough, that I'm happy to start using it with NeptuneMod and work its way into CanaryLib as a replacement for mcstats.


Talking more broadly than adding a Canary category, I'd like to pose the question as to whether having different categories is such a good idea? To me it seems like unnecessary fragmentation - forcing plugins to not be able to see their total stats from one location. As far as plugins go, platform should be irregardless when considering statistics other than platform statistics of course.

Bastian commented 7 years ago

Hey, do you want to use bStats to track stats of CanaryMod itself, or do you want plugin owners who use Canary to be able to register plugins on bStats? If I understood you correctly you want both, right?


Different categories exist for serveral reason as already discussed in other issues which wanted an universal plugin category, so I won't go into details and just sum up some of the points:

jamierocks commented 7 years ago

Absolutely, both is what I'd like. I'm rather well acquainted with CanaryLib, I have no issue making a pr for the Canary Metrics class.

Bastian commented 7 years ago

Can you please tell me the name of the account on bStats for CanaryMod? I'll register a "server implementation" for Canary and transfer it to this account.

jamierocks commented 7 years ago

Sure, jamierocks for now - assuming that this could be changed in the future (although I doubt this'll be necessary). I guess Sponge has the same issue that I'll have here - no distinction between different implementations (SpongeForge, SpongeVanilla - NeptuneMod, CanaryMod).

Bastian commented 7 years ago

Hey, I transfered https://bstats.org/plugin/server-implementation/CanaryMod to your account. It's from the type "Server Implementation" which has way less default charts as normal plugins (in order to make it as flexible as possible with all different types of implementations) which means that you have to create custom charts for stuff like players, etc. Just ask me, if you need help with creating the custom charts. The Metric class and some additional information can be found here: https://github.com/PaperMC/Paper/issues/646#issuecomment-293876337. As different implementation use other config "styles", you also have to create the config file to disable bStats yourself. I'm not familiar with CanaryMod so this is up to you. I recommend to create a seperate folder for bStats which can also be used by plugins.

Bastian commented 7 years ago

I guess Sponge has the same issue that I'll have here - no distinction between different implementations (SpongeForge, SpongeVanilla - NeptuneMod, CanaryMod).

Since version 1.2 of the Metrics classes, they also send the server implementation, too (see https://github.com/BtoBastian/bStats-Metrics/blob/master/bstats-sponge-lite/src/main/java/org/bstats/sponge/MetricsLite.java#L201). This data is not displayed on the website at the moment, but it will after enough plugins switched to the new Metrics class.

Bastian commented 6 years ago

@jamierocks Is there still interest in this? If you need help with the custom charts, I can create them for you (as soon as it works again).

jamierocks commented 6 years ago

Absolutely, I've just been unbelievable busy recently :(

DoNotSpamPls commented 6 years ago

👀