Baton34 / organize-search-engines

Automatically exported from code.google.com/p/organize-search-engines
Other
32 stars 4 forks source link

organize-search-engines broken again in Palemoon 28 #117

Open billmcct opened 6 years ago

billmcct commented 6 years ago

With the new update to Palemoon 28.0 organize-search-engines has become broken. Can no longer drag and drop in the organize interface. I know there were issues with drag and drop But I never experienced them in Palemoon 27.x. The move button does still work to place engines into folders.

Baton34 commented 6 years ago

So Palemoon go to follow the footsteps of Firefox and cut some functions. I can`t do anything with that.

andres99 commented 5 years ago

In Pale Moon 28, the OK button and Enter fail to work in the individual search engine edit window. The Cancel button works though. This means that individual search engines cannot be saved in that window any more. I can confirm the problem with drag and drop but everything else seems to work.

billmcct commented 5 years ago

On my PM 28.1 the OK button is the only way to save. The move button works well for sorting since drag & drop doesn't. I am assuming by enter you mean the keyboard key. That has never worked in any instance of PM I have used to save the config only the OK button.

andres99 commented 5 years ago

On my PM, both the OK button and the Enter key fail - but only in the engine editor window (i.e. when I edit a specific engine). In the management Window the OK button and Enter key work. I am using version 28.2.0a1 (New Moon, based on Pale Moon) (2018-10-27).

billmcct commented 5 years ago

I misread your post. I also cant save in the edit/properties window. Edit: It is still possible to edit the engine.xml file manually using any text editor with PM closed. You will lose where it was at and no way to move it back except by right click and "Move Up". I have been using the same 280+ engines for 7 years and haven't had to edit any lately.

andres99 commented 5 years ago

Well, of course manual editing in the xml file is still possible but I would not need an addon for that.

andres99 commented 5 years ago

I can confirm that the Enter/OK problem is now solved in version 1.96.04. Thank you! I can edit the engines again (and just when I needed).

billmcct commented 5 years ago

I also confirm. Thanks Baton34.

andres99 commented 5 years ago

One more reflection on the drag and drop issue: if it is no longer possible to change the order of search engines by drag and drop in Pale Moon 28, perhaps it would be good to have keyboard shortcuts for Move Up and Move Down. At the moment I could not find any information about this. Do such keyboard shortcuts exist? If not, perhaps it would be useful to add them in some next version?

billmcct commented 5 years ago

Alt U Alt D

andres99 commented 5 years ago

Thank you!

andres99 commented 4 years ago

Strangely enough, I found that in Pale Moon 28.9.0 the OK button in the individual search engine edit window is not working again, or at least so it seems. When I press OK, the window does not close. After that, when I close the window from the X-icon, the changes appear to be saved.

andres99 commented 4 years ago

Thanks for fixing this once again!