BatsResearch / bonito

A lightweight library for generating synthetic instruction tuning datasets for your data without GPT.
BSD 3-Clause "New" or "Revised" License
702 stars 46 forks source link

When the command "pip install -e ." is executed, I get the huggingface-hub version error. #34

Open mohtashim-nawaz opened 3 months ago

mohtashim-nawaz commented 3 months ago

When the command "pip install -e ." is executed, I get the following error.

"pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. llama-index-llms-huggingface 0.2.5 requires huggingface-hub<0.24.0,>=0.23.0, but you have huggingface-hub 0.24.6 which is incompatible."

I think it would be better to mention the huggingface-hub version as well in the requirements.

nihalnayak commented 3 months ago

Thanks for sharing this issue. In setup.py, I haven't tied bonito to huggingface-hub to 0.24.6. It just installs the latest version because of transformers: https://github.com/huggingface/transformers/blob/0a7af19f4dc868bafc82f35eb7e8d13bac87a594/setup.py#L120

Notice they transformers installs the version huggingface-hub>=0.23.2,<1.0. That might be the root cause of your issue.

mohtashim-nawaz commented 2 months ago

I have opened a PR for setting the huggingface-hub to 0.23.5 which solves the problem.