search

Battle-Modders / mod-reforged

The main repository for the Battle Brothers Reforged mod.
16 stars 0 forks source link

Choose for one wording: "Not affected" vs "Unaffected" #505

Open Darxo opened 2 months ago

Darxo commented 2 months ago 
          Might as well change this line to `Not affected by` to match the other tooltips. I remember I had originally preferred to write `Unaffected by` because it is slightly better to convey the meaning that this entity doesn't use Morale instead of "it has morale but is not affected by its the effects of morale state". But I guess both wordings are overall not too big of a deal - but we should use the same wording for all these entities.

_Originally posted by @LordMidas in https://github.com/Battle-Modders/mod-reforged/pull/503#discussion_r1749117736_

Almost all occurences in the Reforged code are currently using Not affected (~25). Only two are using Unaffected term.

In Vanilla both variants are used around 11 times each.

It probably makes sense to choose one variant an go with that