BayAreaMetro / travel-model-two

MTC's Travel Model Two (currently in development)
http://bayareametro.github.io/travel-model-two/
18 stars 14 forks source link

Remove References of Old Transit Skim Files #78

Open AshishKuls opened 3 weeks ago

AshishKuls commented 3 weeks ago

Issue: The transit skimming process in tm2py generates skim files with the naming convention as trnskmAM_KNR_TRN_WLK.omx. However, there is a second set of transit skim files, named transit_skims_period.omx, which are stored in the transit skim folder. These files are no longer produced but are still used by certain UECs in CT-RAMP. They are being carried around in all the latest model runs to get through this issue.

Details: The WalkTransitWalkSkims and WalkTransitDriveSkims UECs in CT-RAMP uses the transitskims{period}.omx files. These UECs are initialized here and here in the code but appears that these UEC objects may no longer be necessary.

Fix: Attempts to delete the transitskims{period}.omx files have shown that the model crashes without those files in place. To resolve this, Java code changes are required. Specifically:

cc @DavidOry

AshishKuls commented 3 weeks ago

@DavidOry we should add this to technical debt as well.

DavidOry commented 3 weeks ago

@DavidOry we should add this to technical debt as well.

Added. How many hours to fix?

AshishKuls commented 3 weeks ago

@DavidOry we should add this to technical debt as well.

Added. How many hours to fix?

May be 8 hours. Haven't looked too closely on needed fix but I assume it should be simple and straightforward.