search

BayesianLogic / blog

The BLOG programming language
http://bayesianlogic.github.io/
BSD 4-Clause "Original" or "Old" License
98 stars 31 forks source link

fix the bug of MHSampler. #302

Open datang1992 opened 9 years ago

datang1992 commented 9 years ago

@lileicc @cberzan @chrisgioia64

As discussed in #301 , the current version of MHSampler is incorrect. The reason is that this implementation doesn't remove the unnecessary variables correctly when they try to build a new instantiation from an old one (some times it will delete less variables, and sometimes it will delete too much variables so that the evidences and queries are not supported).

In this modified version, this problem was fixed. Though this version has not been tested formally.

lileicc commented 9 years ago

@chrisgioia64 to run experiments on all examples

lileicc commented 9 years ago

Looks good.

datang1992 commented 9 years ago

@lileicc The bug in Issue #303 seems has been fixed in my latest commit.