BeID-lab / eIDClientCore

Präambel: Die Humboldt-Universität zu Berlin, Unter den Linden 6, 10099 Berlin, im Folgenden als Humboldt-Universität bezeichnet, stellt für die Anwendung im Zusammenhang mit deutschen hoheitlichen Dokumenten, wie beispielsweise den neuen Personalausweis und den elektronischen Aufenthaltstitel, eine clientseitige eID-Basis-Software zum Bereitstellen der sogenannten eID-Funktionalität, d.h. Ermöglichen eines elektronischen Identitätsnachweises, die sich an den Richtlinien des BSI TR-03110, TR-03112, TR-03130 orientiert, bereit, und zwar in dem Entwicklungszustand, in dem sie sich zum Zeitpunkt der Bereitstellung befindet. Diese Software, die im Folgenden als eIDClientCore bezeichnet wird, hat die Humboldt-Universität von der Bundesdruckerei GmbH, Oranienstraße 91, 10969 Berlin zur Verwendung in Lehre und Forschung sowie zur Bereitstellung an die Öffentlichkeit („Hosten“) für die allgemeine Prüfung und Verwendung durch jedermann erhalten.
15 stars 16 forks source link

Some better statistics output and correction of one error check #51

Closed psytester closed 8 years ago

psytester commented 8 years ago
1261                           retValue = getSamlResponse2(response); 

But printf has used

1263                           printf("%s:%d Error %08lX\n", __FILE__, __LINE__, g_samlResponseReturncode);

-- changed into -->

printf("%s:%d Error %08lX\n", __FILE__, __LINE__, retValue);
wolfmueller commented 8 years ago

Some remarks:

Does somebody know for which reason the Sleep(2000) or usleep(2000) is neded?

psytester commented 8 years ago

I'm fine for any unique layout, as long as I can see separated on console the start and the end of each eID Dialog. If you change "Gesamte Dauer ueber ...", then do it for "Laufzeit" too :) My intention is to measure each single eID Dialog and the total time of requests. It's used for load and stress tests and for long duration tests. For sure we measure the time of service provider and eID Service together, but that's ok for me as itÄs the overall time from triggering the eID until the final result. If you want you can add more differentiated and detailed statistics for the processing time withing SP and eID Service. (means time within "Browser" and within the eID Client part) Please keep the 2 seconds sleep time, but make it changeable via an new command line Option. I use that to make "real stress" with sleep time = zero seconds, some moderate tests with (default) two seconds or some long duration tests with 20 seconds sleep time.

psytester commented 8 years ago

I have updated the source with correct locale

frankmorgner commented 8 years ago

@wolfmueller does the source code comment regarding the sleep answer your question?

looks OK for me

frankmorgner commented 8 years ago

the two commits should be crushed into one, though

psytester commented 8 years ago

If I would know how to merge commits I would do ;-) Some trial and error in Git Shell did not work for me and you know I have usually Browser access only

frankmorgner commented 8 years ago

see https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/ for example

psytester commented 8 years ago

Arghh, one more commit in that branch I will start a new pull request.