search

BearWare / TeamTalk5

TeamTalk 5 Development
www.bearware.dk
Other
322 stars 162 forks source link

Support for streaming Ogg Vorbis files #776

Open a11cf0 opened 3 years ago

a11cf0 commented 3 years ago

Hello. Can support for streaming Ogg Vorbis files be addet at least for Windows clients? Previously it was possible with externaal codecs but since V5.4 it's no longer working.

CoBC commented 3 years ago

I'm totally agree with this, it's a real problem which cause some users to use V5.3 again today just for this feature. But, unfortunately, @bear101 said to me that it's not possible...

kirill-jjj commented 3 years ago

why is it not possible, you have just done the streaming in ogg opus, and Vorbis is also a free codec, if you really can't do it, what is the reason?

zstanecic commented 3 years ago

Yep, more arguments will be needed, othervise blacklisting old clients on a server side basis should be done...

jeremyp3 commented 2 years ago

has this problem been forgotten? we still can't read ogg file on windows

thanks !

kirill-jjj commented 1 year ago

I repeat my question. @bear101, @CoBC Why is it not possible to stream ogg vorbis files? licensing problems? hard code? what exactly prevents adding the most popular format after aac? you added opus with the same license.

bear101 commented 1 year ago

@kirill-jjj You can come an babysit my kids for a week then I'll have time to look into it.

kirill-jjj commented 1 year ago

@bear101, sorry, I was asking about the impossibility, not why it hasn't been done yet.

cyrmax commented 1 year ago

Hello, @bear101. I would be glad to babysit your kids for a some time if I had such an oportunity. And I understand that lack of time can freeze the development. But here we are not talking about free time to implement a feature. We are talking about the fact that you say that implementation is impossible. I know c++ a little and cannot contribute to TeamTalk but I know at least two or three third-party libraries which could help you in decoding vorbis.

We do not force you to implement this feature ASAP. We just ask to not tell that it is impossible and put this implementation to your backlog.

CoBC commented 1 year ago

As this issue is still open, I think no one has sais that it is really impossible now. When I commented on this issue for the first time, I said that @bear101 told me that it is impossible, but it's my mistake, the real words it's more complicated that really impossible, so this will probably be done in the future :)

bear101 commented 1 year ago

It will take a couple of days to implement this. Unfortunately I haven't had the time to do it.