search

BedeGaming / sinks-rollingfile

A serilog sink for rolling files based on size and time
Apache License 2.0
15 stars 20 forks source link

Added more detailed README #17

Closed nblumhardt closed 8 years ago

nblumhardt commented 8 years ago

Howdy! I recently revamped the basic Serilog rolling file sink's README. This PR carries over some of the information there, where it is applicable to this sink.

(I haven't covered everything (no hourly-rolling info) but it should be a good starting point to add those details in down the track.)

Cheers!

nblumhardt commented 8 years ago

Ping :-)

ewilansky commented 8 years ago

Nice job on the readme, Nick. Have you considered adding a retained file count limit similar to the built-in rolling file logger? I'm using your logger because of the log roll on size capability. If you don't have plans to add a retained file count limit, I can add that feature and submit a pull request if you're interested.

nblumhardt commented 8 years ago

@ewilansky wrong way around - I'm maintaining the built-in logger, just came by to offer some help here with the README :-) Cheers though!