search

BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 683 forks source link

Weird runtime in plasmamen.dm #9000

Closed CydiaLamiales closed 1 year ago

CydiaLamiales commented 1 year ago

Occurance Details

Bug Details

image

Reproduction:

Switch species to Plasmaman, pick an alternative helmet style, spawn in, get several runtimes. I reverted to a version before https://github.com/BeeStation/BeeStation-Hornet/pull/8709/ and it was still happening, and I honestly cannot find what's causing it.

tontyGH commented 1 year ago

Just gonna leave this here

It's trying to get the plasmaman outfit from species_outfits in /datum/job/gimmick/ which doesn't have a plasmaman outfit defined

You should test to see if this happens with other jobs

HowToLoLu commented 1 year ago

That specific datum /datum/job/gimmick/ should've been an overridden subtype such as /datum/job/gimmick/vip, which says that something is giving the player a job that shouldn't be given- which happens to be /datum/job/gimmick.

Now- that is a problem that is best left to #8237 to handle, what we can handle right now is that the runtime is caused by some code that doesn't check if it is null or not, which I'll be PRing shortly.

Edit: Upon reading the code for the 14th time now, I realized it has nothing to do with the job subsystem, it's a preference menu thing.