BeeStation / BeeStation-Hornet

99.95% station. 0.05% bees
https://beestation13.com
GNU Affero General Public License v3.0
200 stars 683 forks source link

Remove all direct `text()` calls and replace them with embedded arguments #9130

Closed Crossedfall closed 1 year ago

Crossedfall commented 1 year ago

Per Lummox this is depreciated behavior and should be yanked.

Example:

https://github.com/BeeStation/BeeStation-Hornet/blob/eb2101ec1b0654ea89c8e12126612bfc17296853/code/game/machinery/computer/medical.dm#L85-L90

Should be

dat += "<tr style=[background]><td><A href='?src=[REF(src)];d_rec=[R.fields["id"]]'>[R.fields["name"]]</a></td>"
dat += "<td>[R.fields["id"]]</td>"
dat += "<td><b>F:</b> [R.fields["fingerprint"]]<BR><b>D:</b> [b_dna]</td>"
dat += "<td>[blood_type]</td>"
dat += "<td>[R.fields["p_stat"]]</td>"
dat += "<td>[R.fields["m_stat"]]</td></tr>"
EvilDragonfiend commented 1 year ago

I am on it

Crossedfall commented 1 year ago

Relevant BYOND report https://www.byond.com/forum/post/2872285