search

BeelGroup / Docear-Desktop

Docear's desktop version (GPL)
296 stars 90 forks source link

Repository contains Eclipse project files #478

Open GeorgLink opened 8 years ago

GeorgLink commented 8 years ago

The Docear/Desktop repository contains Eclipse project files. These are files that are not part of the Docear source code, but of the IDE.

The problem: Compiling Docear/Desktop for the first time resulted 8 changed files with 123 additions and 122 deletions. After making one change and testing it, build properties got changed again. These changes did not effect the functionality of Docear/Desktop. If we have to constantly commit these unrelated file changes, it might clutter the actual development.

Ideal Case: I would like for the repository to only contain source files that are related to the functionality of Docear/Desktop. Eclipse project files, I believe, should be individual to each developer and not part of commits and pull-requests.

Solution: What do other's think? Should we look for a solution?

Joeran commented 8 years ago

i also can't see a reason why we should keep eclipse project files on github. @stlanger @genzmehr was there a reason to keep the file on GutHub or can we (Georg) just delete them?

allen501pc commented 8 years ago

By using Eclipse with Maven, I never see the problems about showing lots of building changes. Go back to your problem. I think you can ignore build.xml and something related to Eclipse project by adding the text in .gitignore.

GeorgLink commented 8 years ago

Having the Eclipse project files on Github has the advantage that one can simply clone the repository and import it to Eclipse - very little set up required.

The downside I see is that when ever any developer builds Docear, the same project files get changed. While functional changes usually don't overlap and can be integrated easily, I foresee conflicts with these project files, because they will be changed and included with every commit.

.gitignore is probably the best solution to not commit changes but we can still leave the files in the repository for anyone to clone and get set up.

Maybe I am overthinking this problem and if anyone has experience that this will not be an issue, we can leave it.

Joeran commented 8 years ago

ok, so we leave the proejct files in the repository, and close this ticket?