4.0.7

[Beep6581]

Originally reported on Google Code with ID 1187

Anyone against tagging 4.0.7? This would go in line with what we discusssed in the OSMC
about releasing often - would be good to start with a release now in the beginning
of the month and year, then next one two months from now.

There have been 40 commits since 4.0.6. Apart for the numerous usual bug fixes, these
are the new features:
- exposure compensation filter in the file browser
- exposure compensation added to thumbnail overlay
- new crop ratios
- RGB curves
- RGB preview modes
- RT_* output profiles
- dcraw 9.12 update

Anyone against? If not, I will tag and release the usual linux builds in the evening
of January 1st 2012.

I wish you all inner peace, time and motivation for RT, and camera memory cards that
never fail ;]

Reported by entertheyoni on 2012-01-01 01:39:48

• Blocked on: #1204, #1206

[Beep6581]

I have shortcuts for the new preview modes available within the focus mask patch, may
be a good idea to include in the 4.0.7

Reported by michaelezra000 on 2012-01-01 02:23:28

[Beep6581]

Don't forget the new WB presets, which is now a first class tool better than some commercial
software.

I'm okay for the new revision, BUT keep in mind that the new output file color handling
can show different result than the preview in some cases. It's not a bug, but rather
something that was not coded yet but should really be done. I don't know how much time
it will take, but Jacques and i know what to do to solve this issue. But we'll not
delay the new revision for that, a disclaimer will be required though.

Reported by natureh.510 on 2012-01-01 23:42:28

[Beep6581]

Hombre a warning is a good idea, it will save us time responding to complaints here
and in the forum, but I don't know how to explain it clearly, can you help? The explanation
has to both satisfy the people who don't understand what's going on as well as those
who have a very good idea of how color management works. I'm probably somewhere in
between there.

Where would you put it? Only Windows users (and even only some of those) will be using
installers, so this disclaimer (or rather explanatory warning) would need to appear
to everyone, including those just unzipping RT. One option would be to add a note to
the splash screen. A better one would be to have RT check if this is the first time
the current version is being run, and, if so, display an [ok] popup which could neatly
contain a longer explanation, printed from a text file for example.

There already is a "FirstRun" entry in the options file in the config dir. RT could
check if this version matches the one in AboutThisBuild.txt, and display the popup
if it doesn't, then update it.
The options file in my config dir has "Version=4.0.6.39", in AboutThisBuild its "Version:
4.0.6.41" RT would need to match only the first three numbers, "4.0.6".

Reported by entertheyoni on 2012-01-02 01:02:48

[Beep6581]

Committed shortcuts for all preview modes and beta version of Focus mask.
Other changes since 4.0.6
 fix for flat field corrections
 fix for "white rectangles"
 under the hood maintenance "Major rework of headers inclusion style"
 new camera profiles
 button for neutral values in the Exposure panel
 added support for nrw file extension
 change to default batch edit mode
 updates to language files

Reported by michaelezra000 on 2012-01-02 05:42:30

[Beep6581]

Happy new year everyone!:-)

Reported by michaelezra000 on 2012-01-02 06:06:16

[Beep6581]

" fix for "white rectangles"" do you mean issue 1070? I was just re-reading it, doesn't
appear solved.

Can you comment on the popup and version check idea, if you agree and how long it would
take to code a popup?

Reported by entertheyoni on 2012-01-02 14:11:23

[Beep6581]

Happy new year Michael ;)

About comment #15:

I think that a simple "Disclaimer.txt" or "Know bugs.txt" file bundled with the install
will suffice. And yes, this different output colors problem is for all platforms.

From what i've understood, the preview does not render the output gamma, nothing more.

Reported by natureh.510 on 2012-01-04 00:20:46

[Beep6581]

I still don't know why this should be an issue; gamma is about encoding, not rendering.
 If the gamma is in the appropriate place in metadata, any profile-aware application
should be able to properly decode the gamma-encoded file and properly render it.  If
this isn't being done (I have no time to check it) then I strongly suggest the gamma
feature be reverted until it is implemented properly.

Reported by ejm.60657 on 2012-01-04 00:43:20

[Beep6581]

Any news from Oduis?

Windows builds are downloaded about 10 times more than any other, so I don't want to
tag if we can't have those ready. Can any of you make them?

As for the warning, a text file will have to do for 4.0.7, but I would strongly suggest
adding the notification feature I described above.

Reported by entertheyoni on 2012-01-04 00:48:27

[Beep6581]

About comment 8

Would it be an encoding or rendered, the point is to render it in the preview as well,
which is not done actually.

Reported by natureh.510 on 2012-01-04 01:06:21

[Beep6581]

I'll try to look at this tomorrow, as it looks to be rather urgent... Could you wait
few more days until releasing 4.0.7? I guess 4 days will suffice.

Reported by natureh.510 on 2012-01-04 01:11:26

[Beep6581]

Sure.

Reported by entertheyoni on 2012-01-04 01:31:06

[Beep6581]

My point is that the chain up to preview knows nothing about the output gamma, and need
not; the gamma is basically a form of TRC of the output profile.  It should be part
of the specification of the output profile, and if read correctly by a color aware
program, can then convert that profile to any other device profile, etc, so that proper
color management is maintained.  If should be the same as changing from Adobe RGB to
Prophoto RGB -- no difference so long as a color is within both gamuts; except here
it's even better, since changing gamma doesn't modify the gamut, only how the discretization
is distributed within the gamut.

Reported by ejm.60657 on 2012-01-04 02:48:26

[Beep6581]

Can someone please demonstrate this horrible gamma problem in the latest RT compared
to the same image viewed externally? Does it happen when using RT_sRGB as output profile?

Reported by entertheyoni on 2012-01-05 03:32:27

[Beep6581]

Ready to tag?

Reported by entertheyoni on 2012-01-08 04:34:36

[Beep6581]

Nope. I have almost finished my (huge) patch for the Gamma thing, but will need Jacques'
help to finish it.

Reported by natureh.510 on 2012-01-08 10:42:20

[Beep6581]

Jacques is away (in hospital in fact) until Tuesday, so i may have enough time to track
other bugs until then. If you can't stand 1 more week (and i can understand that),
just publish this release, i'll solve the bug as much and quickly as i can, but i won't
do that in a hurry like i did for 3.0. It's just an intermediate release anyway.

For the record, the Gamma patch is almost finished but i need Jacques' help to finish
it. The AutoWB problem is solved. For the "Control cage" curve bug, given the size
of the culprit patch, it shouldn't take too long to solve it i guess.

Reported by natureh.510 on 2012-01-09 01:02:38

[Beep6581]

Let's wait then.
What happened to Jacques? Please send him my best wishes if you are in contact. I'll
help if I can.

Reported by entertheyoni on 2012-01-09 20:44:10

[Beep6581]

Patch for the Control cage curve has been posted (issue 1181) as well as the AutoWB
that was saved as Custom (issue 988). Still waiting for validation.

Sorry but i can't say more about Jacques' health problem, just ask him directly. But
the gamma preview seems to be subject to debate, as you can see in issue 1151... Still
waiting to be completed/aborted.

Reported by natureh.510 on 2012-01-10 01:04:22

[Beep6581]

Looking at it closely, RT's CMS is messed up by all-in-one functions. If we want to
handle colors properly, i have to plit them in a more comprehensive and logical method
set. I don't know how much time i'll need though. See http://rawtherapee.com/forum/viewtopic.php?p=26491#p26491
too.

Reported by natureh.510 on 2012-01-10 09:49:26

[Beep6581]

How about we release 4.0.7 tomorrow with your submittd patches and a KNOWN BUGS.txt,
and leave the big task for 4.0.8 on Feb 1 or March 1?

How much time do the Mac and Windows builders need?

Reported by entertheyoni on 2012-01-10 10:30:53

[Beep6581]

So, i've learned a lot about color management as it's not my playground, and like Jacques
already said, i think there's no issue in the preview as it show the image using the
Working profile only (without gamma correction though, but i'm not sure of that). The
output file is now correctly generated with the correct gamma curves, incorporated
in them since revision d6976838a524 "New Output Profiles see #issue1151" on december
24, 2011.

Showing the real output image including the output profile and output gamma is an enhancement
that i'm working on, but it will take some time. So please tag the actual code to 4.0.7
if everybody is okay, and put a warning in the detail section of the download page
(or anywhere best suited) that the preview renders the working profile only. To get
correspondance between preview and output file, the user should stick to use Working
profile = Output profile (or the nearest one), and Gamma = default. Having set the
default Working profile to "sRGB" is a good choice for most users.

Reported by natureh.510 on 2012-01-14 11:10:23

[Beep6581]

Ok.

For the average user who processes his raws for the web, and assuming most of the people
viewing his website will be people with a browser that does not support color profiles,
for example Chrome, which sRGB output profile should be used? RT_sRGB, RT_sRGB_g10
or RT_sRGB_gBT709? And output gamma default?

Reported by entertheyoni on 2012-01-14 12:48:24

[Beep6581]

Could you code the suggestion from comment 3?
Check "FirstRun" in options, match just the first three sections of the version number,
so just "4.0.7" from "4.0.7.60", if it does not match the one in AboutThisBuild.txt
then popup a window which just dumps the contents of KNOWNBUGS.txt into an "ok" window,
such as this: http://i.imgur.com/1k7W6.png

We could then be sure users are informed of caveats for each bi-monthly release (RT
peculiarities, known bugs, etc).

Reported by entertheyoni on 2012-01-14 12:58:57

[Beep6581]

I'd like to add *very thin* icons for the RGB,L preview modes - very faint color coding
with color rectangle on the bottom in off position and higher opacity and on same rectangle
on top in ON position, also a Focus mask icon - dashed circle with checkerboard inside,
highlighted in green when enabled. I can do this tomorrow evening the earliest.

Reported by michaelezra000 on 2012-01-14 19:35:04

[Beep6581]

That would be nice; I find them a bit hard to aim at. A little wider would be better.

An idea for you for the focus mask icon, how about the split circle from a film camera's
focus screen, such as these:
http://i.imgur.com/2Hc95.png
http://i.imgur.com/TF2Ji.png

Reported by entertheyoni on 2012-01-14 20:36:46

[Beep6581]

About comment 23: This kind of user will have to select Working=sRGB, Output=RT_sRGB
and Gamma=default, which is the default value of the provided profiles iirc.

About comment 24: I think i'll add a new tab in the About window, and display it as
you suggested. The only problem is that firstrun will always be true unless we change
the setting's folder name, and this is up to the developer who made the build. I'll
drop the boolean FirstRun options and will create VersionOfLastRun, which will be set
to the application's version when quiting. So when starting a new version, this parameter
will still contain the old version number and i'll know that it's a first run. ;)

Could you create the "caveats" text and post it there (at least the formal part)?

Reported by natureh.510 on 2012-01-14 20:43:32

[Beep6581]

"The only problem is that firstrun will always be true unless we change the setting's
folder name"
I don't understand what you mean - did you mean false instead of true?

Actually we don't need FirstRun at all, it should suffice to check Version= in "options"
and in "AboutThisBuild", right?

Reported by entertheyoni on 2012-01-14 21:10:40

[Beep6581]

... damned! You're right, the parameter that i need already exist :-x

Reported by natureh.510 on 2012-01-14 21:30:27

[Beep6581]

DrSlony - thanks for suggestion. Preview mode icons committed in Revision a51f811a74a9

Reported by michaelezra000 on 2012-01-15 21:14:11

[Beep6581]

Reported by natureh.510 on 2012-01-15 23:55:13

• Blocked on: #206

[Beep6581]

Please see test the patch from issue 1206.

I think it's wise to solve issue 1204 too before the release. I'm working on it, it
should be easy to find.

Reported by natureh.510 on 2012-01-16 00:04:58

• Blocked on: #204

[Beep6581]

DrSlony, btw - regarding the button size - I left them think to avoid cluttering UI,
please consider using shortcuts for the preview modes, I actually find them much more
useful than clicking on the buttons (r,g,b,v,Shift-F - see tooltips)
Hombre, great job, I will try to test your patch, luckily tonight, otherwise, tomorrow.

Reported by michaelezra000 on 2012-01-16 00:19:39

[Beep6581]

We need to discuss as a team the default ICM settings in the packaged profiles.
See http://code.google.com/p/rawtherapee/source/detail?r=d25652ca80b3

Reported by michaelezra000 on 2012-01-27 16:25:38

[Beep6581]

The default ICM settings looks fine to me, if we suppose that the most common use case
of RT is producing images targeted to Web galleries. When soft-proofing will be there,
we could make better default choices.

What do you suggest for the "No input ICC" use case?

Reported by natureh.510 on 2012-01-27 19:18:23

[Beep6581]

UI should reflect the name of the auto-matched profile or indicate that no input ICC
profile is available and camera matrix is used instead. This is how Flatfield and Darkframe
auto-options are working.

Reported by michaelezra000 on 2012-01-27 20:21:47

[Beep6581]

Lets further discuss the default input and working profile issues in issue 1220.

Reported by entertheyoni on 2012-01-27 21:20:54

[Beep6581]

Is there anything else pending for 4.0.7 (is this a conservative number?)?

Reported by michaelezra000 on 2012-01-29 22:18:59

[Beep6581]

Don't think so, will tag tomorrow.

I guess things like blue pixels and white/green/magenta squares are holding back 4.1,
and 5.0 is reserved for a new engine. 4.0.7 seems appropriate.

Reported by entertheyoni on 2012-01-29 22:43:07

[Beep6581]

Who will make Windows builds, and for which version?

Reported by entertheyoni on 2012-01-29 22:43:55

[Beep6581]

Morning,
I could make Windows builds on monday evening. Since I am out on customer site tuesdays
and wednesdays I can only make 64bit builds if tagged is later than this afternoon
(because no access to the 32bit machine).
Would upload stuff to visualbakery.com for testing first to weed out any setup etc.
issues.

Reported by oduis@hotmail.com on 2012-01-30 06:45:04

[Beep6581]

Because of the last minute "default" language update, i'll push the corrections to the
french file this evening, just in time for the release i guess, so could builders wait
for it?

Reported by natureh.510 on 2012-01-30 09:49:31

[Beep6581]

quick update: I updated documentation with the description of the preview modes.

Reported by michaelezra000 on 2012-01-30 17:33:07

[Beep6581]

I am making few more updates to the manual and will post here a link to a re-formatted
pdf. Builders, please use this pdf for packaging into builds.

Reported by michaelezra000 on 2012-01-30 21:10:08

[Beep6581]

I'm updating the Polish translations.

Michael the only issue I had in the past with the PDF export was the page count footer.
Optionally the TOC could be recreated. Both quick to fix. If you create the PDF, can
you please just make sure the page count in the footer is correct? TOC is up to you.

Also making a final update to the RELEASE_NOTES.txt

Reported by entertheyoni on 2012-01-30 21:36:03

[Beep6581]

ps. I'm on IRC if anyone wants to collaborate in real-time.
Freenode, channel #rawtherapee
http://webchat.freenode.net/

Reported by entertheyoni on 2012-01-30 21:48:09

[Beep6581]

I don't know what you use to produce the PDF file, but OpenOffice used to include the
TOC as hyperlinks in a separate tab, that's why it has been remove. Is it really necessary
to recreate it?

Reported by natureh.510 on 2012-01-30 21:57:01

[Beep6581]

The TOC was there, but Google Docs' one is not as nice as what you can get with OOo/Libre
Office/whatever. Not really necessary to recreate, but it only takes a few mouse clicks
to make a nicer version, if you have the time.

Reported by entertheyoni on 2012-01-30 22:05:36

[Beep6581]

I don't like GoogleDocs, so i'll let you or anyone else do it ;) (and i don't have the
time too)

Reported by natureh.510 on 2012-01-30 22:08:51

[Beep6581]

Here is the updated manual in PDF format:
http://www.timelessme.com/temp/RT/RawTherapee4UserManual-English_2012-01-29.pdf

Changes: added description of Vibrance, RGB curves and made few corrections in Color/Color
Management section, formatted table of contents, correct page numbering, Bookmark navigation
based on headings, noted last updated date.

Reported by michaelezra000 on 2012-01-30 22:16:05