search

Beep6581 / RawTherapee

A powerful cross-platform raw photo processing program
https://rawtherapee.com
GNU General Public License v3.0
2.94k stars 328 forks source link

ILCE-1 4 Shot ARQ #6482

Open Calandracas606 opened 2 years ago

Calandracas606 commented 2 years ago

RT Crashes when opening a 4 Shot ARQ file from Sony ILCE-1

When first navigating to the file, the thumbnail generates properly and is viewable, but upon clicking on the image to edit, RT Crashes. Looking at the Cache file, all the values in ColorMatrix are set to "nan"

Next time opening RT and navigating to the file, RT Crashes before even displaying the thumbnail.

I have already done some work on this one locally, but thought I should make a bug report.

Will attach some sample 4-Shot and 16-Shot ARQ of X-Rite ColorChecker Passport, cache files, and gdb logs later today.

Calandracas606 commented 2 years ago

I'm new to working on Open Source projects, so my apologies if I did something wrong.

I'm unsure how to assign this task to myself, as I've already done a little bit of work on it on a local banch (haven't pushed my branch to github yet)

Thanatomanic commented 2 years ago

Thanks for working on it! I've assigned you (I am unsure if you can do that yourself). Feel free to make a PR if you have a draft or working fix.

BSLprints commented 2 years ago

Not sure if this is related, but RT uses a lot more memory when working with Sony ARQ files than Adobe Camera Raw does. I had issues with crashing on ARQ files and then upgraded RAM and it was fine after that. In that case it should probably at least give an out of memory error message or something rather than just crashing.

Calandracas606 commented 2 years ago

Not sure if this is related, but RT uses a lot more memory when working with Sony ARQ files than Adobe Camera Raw does. I had issues with crashing on ARQ files and then upgraded RAM and it was fine after that. In that case it should probably at least give an out of memory error message or something rather than just crashing.

this is what I thought at first too, but my machine has 32 GB and I gave Windows a huge (256GB) paging file with no success.

Issue appears to be with the metadata. I have a working fix pending approval, and 16 Shot ARQ files are working now too, so memory wasn't the issue

Lawrence37 commented 2 years ago

In that case it should probably at least give an out of memory error message or something rather than just crashing.

The operating system is responsible for terminating programs when there is not enough memory. Not sure if it's possible to gracefully exit with an error message.

Entropy512 commented 2 years ago

The operating system is responsible for terminating programs when there is not enough memory. Not sure if it's possible to gracefully exit with an error message.

Theoretically, you should be able to see an malloc fail with an error code before termination occurs.

But in practice, once a swap or paging file is in play, the system usually becomes completely unresponsive due to swap thrashing before malloc calls start failing.

Calandracas606 commented 2 years ago

My pull request has been ready for a while, but no activity on this thread. Any chance someone could take a look at it and possibly merge it in?