BelfrySCAD / BOSL2

The Belfry OpenScad Library, v2.0. An OpenSCAD library of shapes, masks, and manipulators to make working with OpenSCAD easier. BETA
https://github.com/BelfrySCAD/BOSL2/wiki
BSD 2-Clause "Simplified" License
1.02k stars 115 forks source link

teardrop threaded rod based on wrong radius #1351

Closed adrianVmariano closed 10 months ago

adrianVmariano commented 10 months ago

The teardrop threaded rod feature doesn't work properly. It teardrops the ID of the screw but leaves the OD alone, which results in OD threads that are much flatter than 45 deg, so presumably a problem for printing? Also note teardrop comes to a point. This is also a result of using the wrong radius. The teardrop needs to be based on the OD of the threading. (This was a subtlety that I was struggling with when I started trying to implement this.)

image

$fn=64;
bottom_half()
threaded_rod(d=6,pitch=2,internal=true, teardrop=true, l=30);
adrianVmariano commented 10 months ago

Fix merged.