Use URL variables and small enhancements

[epiccurious]

Re-create the changes from this PR, including:

• Use variables for the URLs instead of hard-coding in commands
• Use array for Bitcoin Core source domains (.onion and bitcoincore.org) for downloading tarball, checksum, and signatures
• ShellCheck lint changes
• Improve some comments (capitalize and 2nd-person imperative tense)

[epiccurious]

Can we remove these commented lines from install-core?

# # Update $PATH enironment variable to include new user bin
# # shellcheck source=/dev/null
# . $HOME/.profile

[epiccurious]

@BenWestgate Pulled in all the changes from my 73-dont-hardcode-urls-epic fork branch.

Next step is to test the changes, then I'll set the PR ready to review.

[BenWestgate]

Can we remove these commented lines from install-core?

# # Update $PATH enironment variable to include new user bin
# # shellcheck source=/dev/null
# . $HOME/.profile

I don't think so. Since Tails 6 there has been a problem with $PATH automatically updating (before a restart) after ~/.local/bin has been created... I uncommented them in the latest 44-Trust-Individuals to make bails-wallet launch again. But I'm still not sure if they're needed.

[BenWestgate]

Closes #73.

[epiccurious]

The script is stalling, possibly on the guix.sigs step.

Here's the logs:

pastebin.com/cETm7xuM

[BenWestgate]

It's getting stuck from thisssssss: cd bitcoin-core-"$NEW_VER" || {

NEW_VER is assigned in the sub-shell () so it's not available outside of that so it doesn't open up the new directory.

I am going to do that thing with named pipes I told you to fix it. Unless you want to try the new skill.

[BenWestgate]

Here's the cause of the downloads overwriting the screen space messily.

I made a file called wgets with two backgrounded downloads that run simultaneously.

when those commands are run in the main terminal, their output is suppressed to log files.

But when they are run in a subshell it stops suppressing them. This is a wget bug I think or a limitation of linux, somehow.

You can see the difference when the file is sourced and runs in the main process, that may be what I have to do. I'll have to check install-core does not change any variables that will mess up the rest of b and then they should be able to be suppressed again.

[BenWestgate]

@epiccurious: I've cleaned up the terminal output quite a bit and it behaves how you expected now.

Take a look when you get a chance. I also found and protected against a couple race conditions that were previously causing "download" failures more often than they actually happened.

Learned quite a bit today.

[BenWestgate]

@epiccurious: For the -choosedatadir window from Bitcoin Core, do you want me to recreate a simplified substitute of it in zenity with the following? Like this?

[BenWestgate]

@epiccurious: For the -choosedatadir window from Bitcoin Core, do you want me to recreate a simplified substitute of it in zenity with the following? Like this?