Benik / BenikUI

BenikUI is an external ElvUI mod, adding different frame style and new features like detatched portraits and dashboards.
https://www.curseforge.com/wow/addons/benikui
7 stars 6 forks source link

Hekili skinning code has an error: field "backdrop" is nil #42

Closed Myrroddin closed 1 year ago

Myrroddin commented 1 year ago

Log into the game with BenikUI version 4.37 and Hekili version 10.1.0-1.0.0g, and you'll immediately get an error.

20x ...eElvUI_BenikUI/modules/styles/addonskins.lua:291: attempt to index field 'backdrop' (a nil value)
[string "@ElvUI_BenikUI/modules/styles/addonskins.lua"]:291: in function <...eElvUI_BenikUI/modules/styles/addonskins.lua:287>
[string "=[C]"]: in function `CreateButton'
[string "@Hekili/UI.lua"]:1980: in function `CreateDisplay'
[string "@Hekili/UI.lua"]:2829: in function `BuildUI'
[string "@Hekili/Events.lua"]:328: in function `handler'
[string "@Hekili/Events.lua"]:60: in function <Hekili/Events.lua:52>

Locals:
self = <table> {
 GetMacroCastTarget = <function> defined @Hekili/Events.lua:1087
 GetTTD = <function> defined @Hekili/Targets.lua:1103
 IC = <table> {
 }
 EmbedAbilityOptions = <function> defined @Hekili/Options.lua:4039
 Scripts = <table> {
 }
 GetDeathClockByGUID = <function> defined @Hekili/Targets.lua:1088
 GetPetBasedTargetSpells = <function> defined @Hekili/Targets.lua:121
 After = <function> defined @Hekili/Utils.lua:284
 currentSpecOpts = <table> {
 }
 SetDefaultModulePrototype = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:405
 SaveCoordinates = <function> defined @Hekili/UI.lua:3068
 PLAYER_ENTERING_WORLD = true
 PendingSpecializationChange = false
 UpdateDisplayVisibility = <function> defined @Hekili/UI.lua:2060
 ResetSpellCaches = <function> defined @Hekili/Core.lua:580
 IsEnabled = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:447
 Version = "v10.1.0-1.0.0g"
 KeybindInfo = <table> {
 }
 RemoveHold = <function> defined @Hekili/State.lua:6782
 SetMode = <function> defined @Hekili/Options.lua:10755
 baseName = "Hekili"
 BuildUI = <function> defined @Hekili/UI.lua:2777
 GetPetBasedTargetSpell = <function> defined @Hekili/Targets.lua:133
 ToggleHold = <function> defined @Hekili/State.lua:6807
 SpecializationChanged = <function> defined @Hekili/Classes.lua:5937
 Update = <function> defined @Hekili/Core.lua:1445
 DumpProfileInfo = <function> defined @Hekili/Core.lua:2097
 IsRetail = <function> defined @Hekili/Hekili.lua:22
 GetNumTargetsAboveHealthPct = <function> defined @Hekili/Targets.lua:1259
 GetNextPrediction = <function> defined @Hekili/Core.lua:1332
 UpdateUseItems = <function> defined @Hekili/Events.lua:658
 SetSpecOption = <function> defined @Hekili/Options.lua:3821
 GetDefaults = <function> defined @Hekili/Options.lua:445
 dumpKeyCache = <table> {
 }
 GetPredictionFromAPL = <function> defined @Hekili/Core.lua:657
 SetEnabledState = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:420
 GetDisplayByName = <function> defined @Hekili/Core.lua:1414
 Options = <table> {
 }
 ReInitialize = <function> defined @Hekili/Core.lua:167
 GetSpellLinkWithTexture = <function> defined @Hekili/Utils.lua:582
 IsSpellEnabled = <function> defined @Hekili/Core.lua:574
 GetAbilityInfo = <function> defined @Hekili/Classes.lua:5882
 IsSpellKnown = <function> defined @Hekili/Core.lua:561
 State = <table> {
 }
 OnEnable = <function> defined @Hekili/Core.lua:186
 RestoreDefault = <function> defined @Hekili/Classes.lua:1115
 FindStringInInventoryItemTooltip = <function> defined @Hekili/Utils.lua:680
 CheckStack = <function> defined @Hekili/Core.lua:390
 CmdLine = <function> defined @Hekili/Options.lua:9518
 PopStack = <function> defined @Hekili/Core.lua:301
 IsDisplayActive = <function> defined @Hekili/UI.lua:2170
 GetNumTargetsBelowHealthPct = <function> defined @Hekili/Targets.lua:1283
 SetupPetBasedTargetDetection = <function> defined @Hekili/Targets.lua:147
 ShowDiagnosticTooltip = <function> defined @Hekili/UI.lua:2977
 Notify = <function> defined @Hekili/Options.lua:10716
 OnInitialize = <function> defined @Hekili/Core.lua:58
 NewModule = <function> defined @Ace3/AceAddon-3.0/AceAddon-3.0.lua:231
 FindStringInSpellTooltip = <function> defined @Hekili/Utils.lua:669
 AddToStack = <function> defined @Hek

To Reproduce Log into the game with both addons.

Expected behavior The backdrop field is nil. It might be Backdrop but I cannot confirm.

Screenshots N/A

Please include the addon and game versions:

Additional context Add any other context about the problem here.

Azilroka commented 1 year ago

You probably aren't updated on AddOnSkins.

Benik commented 1 year ago

You probably aren't updated on AddOnSkins.

Nope was from my side :)

Benik commented 1 year ago

Fixed on dev, link: https://github.com/Benik/BenikUI/archive/refs/heads/development.zip Thank you :)