Benjamin-Lee / deep-rules

Ten Quick Tips for Deep Learning in Biology
https://benjamin-lee.github.io/deep-rules/
Other
227 stars 45 forks source link

Add zipcode metadata required for submission #324

Closed rasbt closed 3 years ago

rasbt commented 3 years ago

Did you add yourself as a contributor if this is your first contribution?

Adds zip code to author data

Benjamin-Lee commented 3 years ago

Actually, does it make sense to have the value be a list of the number itself? And speaking of which, should we represent it as a string? I do know horrible things can happen when you treat zip codes as numbers, though I doubt it will matter here.

rasbt commented 3 years ago

Actually, does it make sense to have the value be a list of the number itself?

I was thinking that if affiliations is a list, then the zip code should probably also be a list. Although we really don't need multiple zip codes for the submission.

I do know horrible things can happen when you treat zip codes as numbers, though I doubt it will matter here.

Yeah, I don't think it matters here. I was thinking of it as just something you would copy and paste into the submission form.

EDIT: Just changed it to a string though, because why not :)

cgreene commented 3 years ago

What about just asking that folks include zipcodes for at least one affiliation on that line? I'm wondering if that's easier or harder.

fmaguire commented 3 years ago

Also worth noting that not all currently listed authors are based in the US (including myself), therefore don't have zipcodes.

rasbt commented 3 years ago

Either way would be fine to me. I think @Benjamin-Lee would just copy & paste the first value into the submission field anyway. I can change it to a single value.

Benjamin-Lee commented 3 years ago

Single value works for me. Let’s just go with that since it reduces the complexity.

On Feb 3, 2021, at 12:46 PM, Finlay Maguire notifications@github.com wrote:

 Also worth noting that not all currently listed authors are based in the US (including myself), therefore don't have zipcodes.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

rasbt commented 3 years ago

Good point by @fmaguire

Also worth noting that not all currently listed authors are based in the US (including myself), therefore don't have zipcodes.

for those cases, people could add a "- postalcode: ..." entry? Looking at your submission form, Ben, I think either zip code or postal code would be ok. 106531764-dda2df00-64bc-11eb-8a81-0550449bc3e0

Benjamin-Lee commented 3 years ago

Let’s go with “postcode” then. An arbitrary string I can put in the form to make them happy will suffice.

On Feb 3, 2021, at 12:46 PM, Finlay Maguire notifications@github.com wrote:

 Also worth noting that not all currently listed authors are based in the US (including myself), therefore don't have zipcodes.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

rasbt commented 3 years ago

Let’s go with “postcode” then. An arbitrary string I can put in the form to make them happy will suffice.

alright, done. And like you said, i think we can be flexible because it's just something you have to copy and paste and doesn't go through computational pipelines