The bug list of "disallow-team-member-islands: false"

Noogear commented 2 weeks ago

Expected behavior

This can enable players to be the island owners of more than one island. A configuration is needed to limit the max number of islands a player can be the owner of.
A new placeholder is needed to show the number of excavations when being the island owner instead of being a member. When I use the task plugin for judgment, others only need to go to others' islands as members to directly complete the task.
Using the command "/ob go", the default return is the last island as a member, not as the owner.

Observed/Actual behavior

*

Steps/models to reproduce

*

BentoBox version

Running: PAPER 1.21.1. (1.21.1-DEV-6fff957 (MC: 1.21.1)) BentoBox version: 2.7.0 Database: JSON Loaded Game Worlds: oneblock_world (OneBlock): 主世界, 下界 Loaded Addons: AOneBlock 1.17.1-SNAPSHOT-b413 (ENABLED) Biomes 2.2.0-SNAPSHOT-b277 (ENABLED) Challenges 1.3.2-SNAPSHOT-b567 (ENABLED) Level 2.15.0-SNAPSHOT-b586 (ENABLED) TopBlock 1.0.2-SNAPSHOT-b27 (ENABLED) Warps 1.15.1-SNAPSHOT-b373 (ENABLED)

Plugin list

No response

Other

No response

tastybento commented 1 week ago

Can you explain more?

This can enable players to be the island owners of more than one island.

Yes, this is correct.

A configuration is needed to limit the max number of islands a player can be the owner of.

There is a configuration - it's in the config.yml. Look for concurrent islands.

A new placeholder is needed to show the number of excavations when being the island owner instead of being a member. When I use the task plugin for judgment, others only need to go to others' islands as members to directly complete the task. Using the command "/ob go", the default return is the last island as a member, not as the owner.

Please explain more. The translation is not good here.

Noogear commented 1 week ago

This can enable players to be the island owners of more than one island.

First set this player as a member, and then transfer the ownership of the island to him. I had set "concurrent-islands: 1".

A new placeholder is needed to show the number of excavations when being the island owner instead of being a member. When I use the task plugin for judgment, others only need to go to others' islands as members to directly complete the task. Using the command "/ob go", the default return is the last island as a member, not as the owner.

When you are set as a member and have your own island, the command "/ob go" takes you back to the island where you are a member latest.

%aoneblock_my_island_lifetime_count% will have problems after you become a member. When you are on your own island, it shows that of your own island. When you are on the island as a member, it shows that of the island.

tastybento commented 5 days ago

Some of these are expected operation.

This can enable players to be the island owners of more than one island.

First set this player as a member, and then transfer the ownership of the island to him. I had set "concurrent-islands: 1".

We previously tried to prevent this, but it was hard to track. That is why there is a setting to allow team members to be in multiple teams. However, I'll see if there's a way to prevent it.

A new placeholder is needed to show the number of excavations when being the island owner instead of being a member. When I use the task plugin for judgment, others only need to go to others' islands as members to directly complete the task. Using the command "/ob go", the default return is the last island as a member, not as the owner.>

When you are set as a member and have your own island, the command "/ob go" takes you back to the island where you are a member latest.

Correct. This is expected, you go to the island you were last operating on. If you wish to go to different islands then hit TAB when you use /is go to see the other islands or use /is homes.

%aoneblock_my_island_lifetime_count% will have problems after you become a member. When you are on your own island, it shows that of your own island. When you are on the island as a member, it shows that of the island.

This might be able to be fixed, but only in a limited way because players can own more than one island now. Anyway, I can see if I can tighten this up.

Noogear commented 5 days ago

Is there a way to completely turn off the team function and make all the originally set members invalid? After setting "disallow-team-member-islands: true" after adding members, there will be a problem when the members enter the command "/ob team" on my island. He will encounter the situation where he is unable to exit the island team.

tastybento commented 5 days ago

Is there a way to completely turn off the team function and make all the originally set members invalid? After setting "disallow-team-member-islands: true" after adding members, there will be a problem when the members enter the command "/ob team" on my island. He will encounter the situation where he is unable to exit the island team.

You would have to use Admin Kick command to kick players from teams.

Noogear commented 5 days ago

Is there a way to completely turn off the team function and make all the originally set members invalid? After setting "disallow-team-member-islands: true" after adding members, there will be a problem when the members enter the command "/ob team" on my island. He will encounter the situation where he is unable to exit the island team.

You would have to use Admin Kick command to kick players from teams.

I have tried. It will show that the owner of the island cannot be kicked out. It will wrongly consider the member as the owner.

tastybento commented 5 days ago

Aha, yes, I see the issue. The Admin Kick command has not been updated to support multiple islands yet. When you execute it, it doesn't know which island you are talking about. That needs to be updated, I'll work on it.

tastybento commented 5 days ago

The work around is that if the player is on the team island, it should work. He will need to teleport there.

tastybento commented 5 days ago

FYI: This is a BentoBox change and I'm putting it into the new 3.0.0 version, which runs only on 1.21.x. I hope that isn't a problem...

Noogear commented 5 days ago

The work around is that if the player is on the team island, it should work. He will need to teleport there.

Setting "disallow-team-member-islands: true" after adding members, there will be a problem. If there is a way to completely disable the member function, it might be a little better. I found that as long as trusted people are given high enough permissions, there is no difference from members.

Noogear commented 5 days ago

In fact, referring to the design of some other plugins, it would be better if players could create multiple permission templates and then assign them to different groups of people. The member function seems to have many problems.

tastybento commented 5 days ago

Interesting. Tell me more.

Noogear commented 5 days ago

Interesting. Tell me more.

Players can create their own permission group templates, just like the permission groups in LuckPerms. After setting up the template, the owner only needs to assign the template to trusted personnel to complete the configuration simply. This improves the allocation of the setting permissions to a certain extent. Obviously, this is a huge innovation for the current permission allocation. It will bring a lot of workload.

BentoBoxWorld / AOneBlock