BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
334 stars 137 forks source link

Add a BARTERING flag #1420

Open Poslovitch opened 4 years ago

Poslovitch commented 4 years ago

Description

Is your feature request related to a problem?

As of 1.16, players can barter with Piglins. See: https://minecraft.gamepedia.com/Bartering (from #1191).

Describe the solution you'd like us to implement.

Bartering occurs when a player either throws a gold ingot near the piglin or uses the gold ingot on it.

We should therefore add a BARTERING protection flag that prevents players from "clicking" on the Piglins to barter with them.

Preventing piglins from picking up the gold is more tricky, since the gold can be dropped by a visitor, an island member, a dropper...

Describe alternatives you've considered.

Covering the bartering with the TRADING flag will most likely lead in users asking us to split it later on.

Additional context

None.

Poslovitch commented 4 years ago

According to SPIGOT-5803, additionnal Piglin-related API is to be added, especially related to bartering.

tastybento commented 4 years ago

I think we need to wait for a bartering event to cancel. We can then act on that. Until then, let's just keep this open.