BentoBoxWorld / BentoBox

Expandable Minecraft server plugin for island-type games like SkyBlock or AcidIsland.
https://bentobox.world
Eclipse Public License 2.0
337 stars 140 forks source link

settings keep changing from co-owner to owner #1975

Closed Razorxd1993 closed 2 years ago

Razorxd1993 commented 2 years ago

Expected behavior

My players tell me that the settings keep changing from co-owner to owner

how to fix this or is this bug known ?

Observed/Actual behavior

-

Steps/models to reproduce

-

BentoBox version

1.20.0

Plugin list

nothing that would be decisive

Other

No response

BONNe commented 2 years ago

Could you tell me more? Which settings are changing?

Razorxd1993 commented 2 years ago

all settings under -> Settings Burning fire / monster spawn etc

The Change Settings always resets itself to Owner Screenshot_1

BONNe commented 2 years ago

And when the change happnes? After the server restart or it is happening after the settings menu closes?

Razorxd1993 commented 2 years ago

Always after a server restart next bug is that co-owners also can not make team/coop invitations

tastybento commented 2 years ago

What kind of database are you using? Can you post the results of bbox version so we can see what you are using? To me, if the settings are being reset then it indicates that the island data is not saving correctly for some reason.

Razorxd1993 commented 2 years ago

[17:59:24 INFO]: BentoBox version: 1.20.0 [17:59:24 INFO]: Datenbank: JSON [17:59:24 INFO]: Geladene Spielewelten: [17:59:24 INFO]: oneblock_world (OneBlock): Oberwelt, Nether, End [17:59:24 INFO]: Geladene Addons: [17:59:24 INFO]: AOneBlock 1.9.0 (ENABLED) [17:59:24 INFO]: Bank 1.4.0 (ENABLED) [17:59:24 INFO]: Biomes 2.0.0 (ENABLED) [17:59:24 INFO]: Border 3.2.0 (ENABLED) [17:59:24 INFO]: Challenges 0.8.4 (ENABLED) [17:59:24 INFO]: Chat 1.1.4 (ENABLED) [17:59:24 INFO]: ControlPanel 1.13.0 (ENABLED) [17:59:24 INFO]: DimensionalTrees 1.6.0 (ENABLED) [17:59:24 INFO]: ExtraMobs 1.12 (ENABLED) [17:59:24 INFO]: Level 2.9.0 (ENABLED) [17:59:24 INFO]: Likes 2.1.1 (ENABLED) [17:59:24 INFO]: MagicCobblestoneGenerator 2.3.0 (ENABLED) [17:59:24 INFO]: Visit 1.4.0 (ENABLED) [17:59:24 INFO]: Warps 1.11.2 (ENABLED)

Razorxd1993 commented 2 years ago

After each restart the values under commandRanks reset from 900 to 1000.

here is an excerpt from the .json "commandRanks": { "/ob team coop": 1000, "/ob team trust": 1000, "/ob team invite": 1000, "/ob team promote": 1000, "/ob sethome": 500, "/ob setname": 1000, "/ob ban": 1000, "/ob unban": 1000, "/ob expel": 1000, "/ob team kick": 1000, "/ob team uncoop": 1000, "/ob team untrust": 1000, "/ob team demote": 1000, "/ob deletehome": 500, "/ob renamehome": 500, "/ob border": 1000, "/ob teamchat": 1000, "/ob chat": 1000

CHANGE_SETTINGS was applied after reboot "CHANGE_SETTINGS": 900,

and coop players are no longer entered once the inviter goes offline

Razorxd1993 commented 2 years ago

okay, here's what i found out. "CHANGE_SETTINGS": 1000 - this is not applied "commandRanks": - this is also not applied

all other settings are applied, only CHANGE_SETTINGS and the category: commandRanks are not applied

how can this be fixed ?

tastybento commented 2 years ago

I ran some tests and I cannot replicate what you are seeing with CHANGE_SETTINGS or commandRanks. I am viewing the JSON for the island in an editor and I could confirm that commandRank settings are instantly set when you change the ranks. For CHANGE_SETTINGS the value is set when the server shuts down. When restarting the server, the values stay and when I login I see the same values. So... I am not currently seeing where this issue is occurring.

I'll let @BONNe have a chance to comment, but I'm not sure why you are seeing this right now.

Razorxd1993 commented 2 years ago

I have the suspicion that the plugin does not load the data from the database folder on restart, but from the database_backup folder This problem also does not occur with all islands, but only sporadically.

Edit: I just read in the config that the max-saved-island-per-tick and the max-saved-player-per-tick were since far below the default value, can this cause the problem ?

tastybento commented 2 years ago

What values do you have in the config for those items?

The back up database files are never read, just written so I don't think that is the issue.

Razorxd1993 commented 2 years ago

The values for both were at 20... Default would actually be 200. How they were changed I curiously do not know, maybe my old dev XD I have the values times again set to default and will report tomorrow whether it has improved :)

tastybento commented 2 years ago

Actually, those values are what are in the config.yml file by default even though it says 200. I think that it is too low and needs changing. How many islands do you have?

Razorxd1993 commented 2 years ago

The Database folder contains 93 island files Played are currently 20-25 active

Razorxd1993 commented 2 years ago

Okay even after changeover, nothing has changed. The command sequence is reset again and the registered coop player removed after a restart.

See picture

It is again not possible for the co-owner to invite players or add them to the coop team.

Screenshot_20220505-122957_Chrome

BONNe commented 2 years ago

The only thing that comes to mind about this issue is some file change protections. May be server cannot change the content of that file. Do you have any errors in the log file after the player changed any of settings in /[player_cmd] settings

About coop players... well, coop status is temprararely. After island members go offline, coop status is removed. Trust is permanent.

Razorxd1993 commented 2 years ago

Hi thanks for your answer.

After I updated my network to the 1.19, everything works smoothly. The permissions for owner and co-owner were also gone overnight (before the update to 1.19).

Kind regards

PS.: OneBlock runs stable and without errors on the 1.19, except for holograms, because yes Holographic Displays 3.0.0 does not create any with OneBlock - would the integration of Decent Holograms be possible? :)