UpgradableHoppers not working beneath y=0

Mappors commented 2 years ago

Expected behavior

Being able to link UpgradableHoppers to chests which are located beneath y-level 0. Also being able to enable suction etc.

Observed/Actual behavior

It has been blocked by Bentobox's trust system. But only beneath y-level 0.

Steps/models to reproduce

Place an UpgradableHopper on an island and try to link it to a chest which is located beneath y-level 0.

BentoBox version

Running PAPER 1.18.2.
BentoBox version: 1.20.1-SNAPSHOT-b2243
Database: JSON
Loaded Game Worlds:
skyblock_world (SkyBlock): Overworld, Nether, The End
Loaded Addons:
Biomes 2.1.0-SNAPSHOT-b225 (ENABLED)
Border 3.3.0-SNAPSHOT-b136 (ENABLED)
BSkyBlock 1.15.2 (ENABLED)
Challenges 1.1.0-SNAPSHOT-b486 (ENABLED)
Chat 1.1.4 (ENABLED)
ControlPanel 1.13.0 (ENABLED)
DimensionalTrees 1.6.0 (ENABLED)
ExtraMobs 1.12 (ENABLED)
IslandFly 1.10.0-SNAPSHOT-b140 (ENABLED)
Level 2.9.1-SNAPSHOT-b500 (ENABLED)
Limits 1.19.1-SNAPSHOT-b295 (ENABLED)
MagicCobblestoneGenerator 2.5.0-SNAPSHOT-b246 (ENABLED)

Plugin list

Plugins (69): AdvancedGift, AntiAFKPlus, AreaShop, AuctionHouse, AutoPickup2, BedrockMiner, BentoBox, BetonQuest, BlockLocker, BossShopPro, BottledExp, BuycraftX, ChestShop, ChestShopNotifier, Citizens, CitizensIntergration, CleanroomGenerator, CMI, CMILib, DeathMessages, DeluxeCoinflip, DeluxeCombat, DeluxeCombat_Addon_WG, Duels, DungeonSystem, eco, EcoEnchants, EffectLib, FastAsyncWorldEdit (WorldEdit), FeatherBoard, GUIHelper, HeadDatabase, HyperDrive, Hyperverse, InteractiveBoard, ItemShops, LagAssist, LeaderHeadsRevamped, LibsDisguises, LimitCrafting, LimitedUses, LogBlock, mcMMO, Minepacks, MobFarmManager, MorphRedeem, MythicMobs, NametagEdit, NBTAPI, NetworkManager, ParticlesMenu, PlaceholderAPI, PlayerParticles, PremiumVanish, ProtocolLib, RoseStacker, SimplePets, Spartan, SpecializedCrates, TCRestart, TradeSystem, UltimateShoutPro, UltimateVotes, UpgradeableHoppers, Vault, ViaBackwards, ViaVersion, WGEF-Reborn, WorldGuard

Other

---------<- INFO ->---------
Version: 4.0.1 Latest: 4.3.3
Wiki: https://github.com/Angeschossen/UpgradeableHoppers/wiki
Page: https://www.spigotmc.org/resources/69201
Licensed to: https://www.spigotmc.org/members/179340
Language contains 3rd party placeholders: No
---------<- INFO ->---------

Requested info from UpgradableHoppers by Bentobox developer BONNe1704 to @Angeschossen: -How protection has been implemented in UpgradableHoppers -Which part of Bentobox API is being used in UpgradableHoppers to detect if an item should be protected, and how it's used

BONNe commented 2 years ago

Well, the question still remains... How does UpgradableHoppers check for trust or allowance?

Which system is used for that? And how it is executed?

To my knowledge, BentoBox does not use Y in most "allowance" detection systems and relays only on X and Z ... grid location.

That is the reason, why I would know which part BentoBox API code you use, as it would indicate which is the "buggy" part that prevents your system to work.

And, because the "protection" is implemented by the Closed Source plugin that is not associated with the BentoBox team at all, there is no way how it could be fixed from the BentoBox side without providing the information I requested.

Angeschossen commented 2 years ago

All explained here: https://github.com/BentoBoxWorld/BSkyBlock/issues/473 The issue has been marked as solved. The API has been fixed according to the issue state. However, I'm unsure if the latest versions of your plugins contains this newer version.

BONNe commented 2 years ago

Version 1.21.0 contains the fix with the protection bounding box.

So the issue is fixed, and the user is just required to update his BentoBox version.

By version report user is using BentoBox version: 1.20.1-SNAPSHOT-b2243 and not 1.21

BentoBoxWorld / BentoBox