ItemParser no longer works correctly

[tastybento]

Expected behavior

ItemParser should parse items correctly.

Observed/Actual behavior

When running the ItemParserTest tests, they fail because the item is no longer parsed correctly and so is returned as a null.

Steps/models to reproduce

Run the ItemParseTest class. The following no longer parse:

Potions:

• "POTION:STRENGTH:1:::4"
• "POTION:STRENGTH:1::SPLASH:3"

Banners don't work either:

• "WHITE_BANNER:1:::::::::::::"
• "WHITE_BANNER:2"
• "RED_BANNER:1"

Tipped arrows:

• "TIPPED_ARROW:WEAKNESS::::1"

Normal items:

• "WOODEN_SWORD:3:2"
• "WOODEN_SWORD:CMD-23151212:2"

I fixed the tests, but some things don't work and I suspect ItemParset needs fixing.

In regards to potions, it looks like PotionData (which has been deprecated) cannot make extended potions or upgraded potions any more.

The custom item thing doesn't work.

BentoBox version

> bbox v
[22:51:19 INFO]: Running PAPER 1.20.2.
[22:51:19 INFO]: BentoBox version: 2.0.0-SNAPSHOT-LOCAL
[22:51:19 INFO]: Database: JSON
[22:51:19 INFO]: Loaded Game Worlds:
[22:51:19 INFO]: acidisland_world (AcidIsland): Overworld, Nether, The End
[22:51:19 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[22:51:19 INFO]: oneblock_world (OneBlock): Overworld, Nether*, The End*
[22:51:19 INFO]: Loaded Addons:
[22:51:19 INFO]: AcidIsland 1.18.1-SNAPSHOT-b999 (ENABLED)
[22:51:19 INFO]: AOneBlock 1.14.2 (ENABLED)
[22:51:19 INFO]: Bank 1.7.0 (DISABLED)
[22:51:19 INFO]: Biomes 2.1.1 (ENABLED)
[22:51:19 INFO]: Border 4.1.1 (ENABLED)
[22:51:19 INFO]: BSkyBlock 1.16.1 (ENABLED)
[22:51:19 INFO]: CauldronWitchery 2.0.1 (ENABLED)
[22:51:19 INFO]: Challenges 1.2.0 (ENABLED)
[22:51:19 INFO]: Chat 1.1.4 (ENABLED)
[22:51:19 INFO]: CheckMeOut 1.1.1 (ENABLED)
[22:51:19 INFO]: DimensionalTrees 1.6.0 (ENABLED)
[22:51:19 INFO]: ExtraMobs 1.12 (ENABLED)
[22:51:19 INFO]: Greenhouses 1.7.3 (ENABLED)
[22:51:19 INFO]: InvSwitcher 1.11.0 (ENABLED)
[22:51:19 INFO]: IslandFly 1.11.0 (ENABLED)
[22:51:19 INFO]: Level 2.11.0 (ENABLED)
[22:51:19 INFO]: Likes 2.3.1 (ENABLED)
[22:51:19 INFO]: Limits 1.19.2-SNAPSHOT-LOCAL (ENABLED)
[22:51:19 INFO]: MagicCobblestoneGenerator 2.5.1 (ENABLED)
[22:51:19 INFO]: TwerkingForTrees 1.4.3 (ENABLED)
[22:51:19 INFO]: Visit 1.6.0 (ENABLED)
[22:51:19 INFO]: VoidPortals 1.5.0.0 (ENABLED)
[22:51:19 INFO]: Warps 1.13.0 (ENABLED)

Plugin list

> plugins
[22:51:36 INFO]: Server Plugins (17):
[22:51:36 INFO]: Bukkit Plugins:
[22:51:36 INFO]:  - BentoBox, BentoBox-AcidIsland, BentoBox-AOneBlock, BentoBox-Bank, BentoBox-Biomes, BentoBox-BSkyBlock, BentoBox-CauldronWitchery, BentoBox-Challenges, BentoBox-CheckMeOut, BentoBox-Greenhouses
[22:51:36 INFO]:  BentoBox-IslandFly, BentoBox-Level, BentoBox-Likes, BentoBox-Limits, BentoBox-MagicCobblestoneGenerator, BentoBox-Visit, BentoBox-Warps

Other

No response

[tastybento]

FYI @BONNe - I'll try and look at this some more when I'm not so tired. Something has changed here...

[tastybento]

@BONNe I think you fixed this recently, right?

[BONNe]

Yes