BentoBoxWorld / CaveBlock

CaveBlock addon for BentoBox. An interesting variation from Skyblock, where your goal is to survive in a cube of stone!
Eclipse Public License 2.0
16 stars 6 forks source link

CME when generating new worlds #66

Closed HSGamer closed 2 years ago

HSGamer commented 3 years ago

Expected behavior

Worlds get generated successfully

Observed/Actual behavior

Get ConcurrentModificationException when generating new worlds (when setting blocks)

Steps/models to reproduce

Error: https://pastebin.com/hsSEdTwh How to: Download & Start on a fresh server

BentoBox version

[12:00:36] [Server thread/INFO]: Running PAPER 1.17.1. [12:00:36] [Server thread/INFO]: BentoBox version: 1.18.0-SNAPSHOT-b2176 [12:00:36] [Server thread/INFO]: Database: JSON [12:00:36] [Server thread/INFO]: Loaded Game Worlds: [12:00:36] [Server thread/INFO]: Loaded Addons: [12:00:36] [Server thread/INFO]: CaveBlock 1.15.0-SNAPSHOT-b406 (ERROR)

Plugin list

BentoBox

Other

No response

tastybento commented 3 years ago

Hmm. I cannot replicate. This appears to be a server bug because I don't see any reference in the crash report to BentoBox or CaveBlock being involved. I just tried a clean setup using latest d/l of everything and it all seemed to work. I'm not sure what the issue would be here.

% java -jar paper-1.17.1-334.jar --nogui
System Info: Java 16 (OpenJDK 64-Bit Server VM 16.0.1+9) Host: Mac OS X 11.5 (x86_64)
Loading libraries, please wait...
[22:16:44 INFO]: Environment: authHost='https://authserver.mojang.com', accountsHost='https://api.mojang.com', sessionHost='https://sessionserver.mojang.com', servicesHost='https://api.minecraftservices.com', name='PROD'
[22:16:45 INFO]: Reloading ResourceManager: Default, bukkit
[22:16:46 INFO]: Loaded 7 recipes
[22:16:47 INFO]: Starting minecraft server version 1.17.1
[22:16:47 INFO]: Loading properties
[22:16:47 INFO]: This server is running Paper version git-Paper-334 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: a55617d)
[22:16:47 INFO]: Server Ping Player Sample Count: 12
[22:16:47 INFO]: Using 4 threads for Netty based IO
[22:16:47 INFO]: Default game type: SURVIVAL
[22:16:47 INFO]: Generating keypair
[22:16:47 INFO]: Starting Minecraft server on *:25565
[22:16:47 INFO]: Using default channel type
[22:16:47 INFO]: Paper: Using Java 11 compression from Velocity.
[22:16:47 INFO]: Paper: Using Java cipher from Velocity.
[22:16:48 INFO]: [BentoBox] Loading BentoBox v1.18.0-SNAPSHOT-b2176
[22:16:48 INFO]: Server permissions file permissions.yml is empty, ignoring it
[22:16:48 INFO]: [BentoBox] Enabling BentoBox v1.18.0-SNAPSHOT-b2176
[22:16:48 INFO]: [BentoBox] Loading Settings from config.yml...
[22:16:50 INFO]: [BentoBox] Loading addons...
[22:16:50 INFO]: [BentoBox] Loaded 1 addons.
[22:16:50 INFO]: Preparing level "world"
[22:16:51 INFO]: Preparing start region for dimension minecraft:overworld
[22:16:51 INFO]: Time elapsed: 367 ms
[22:16:51 INFO]: Preparing start region for dimension minecraft:the_nether
[22:16:51 INFO]: Time elapsed: 193 ms
[22:16:51 INFO]: Preparing start region for dimension minecraft:the_end
[22:16:52 INFO]: Time elapsed: 176 ms
[22:16:52 INFO]: Running delayed init tasks
[22:16:52 INFO]: [BentoBox] Enabling game mode addons...
[22:16:52 INFO]: [BentoBox] Enabling CaveBlock (1.15.0-SNAPSHOT-b406)...
[22:16:52 INFO]: [BentoBox] Creating CaveBlock world ...
[22:16:55 INFO]: Preparing start region for dimension minecraft:caveblock-world
[22:16:55 INFO]: Time elapsed: 485 ms
[22:16:55 INFO]: [BentoBox] [CaveBlock] Creating CaveBlock's Nether...
[22:16:55 ERROR]: No key layers in MapLike[{}]; No key structures in MapLike[{}]
[22:16:58 WARN]: Unable to find spawn biome
[22:16:59 INFO]: Preparing start region for dimension minecraft:caveblock-world_nether
[22:17:00 INFO]: Time elapsed: 1089 ms
[22:17:00 INFO]: [BentoBox] [CaveBlock] Creating CaveBlock's End World...
[22:17:00 ERROR]: No key layers in MapLike[{}]; No key structures in MapLike[{}]
[22:17:00 WARN]: Unable to find spawn biome
[22:17:01 INFO]: Preparing start region for dimension minecraft:caveblock-world_the_end
[22:17:02 INFO]: Time elapsed: 1352 ms
[22:17:02 INFO]: [BentoBox] Enabling other addons...
[22:17:03 INFO]: [BentoBox] Addons successfully enabled.
[22:17:03 INFO]: 
  ____             _        ____
 |  _ \           | |      |  _ \             by tastybento and Poslovitch
 | |_) | ___ _ __ | |_ ___ | |_) | _____  __  2017 - 2020
 |  _ < / _ \ '_ \| __/ _ \|  _ < / _ \ \/ /
 | |_) |  __/ | | | || (_) | |_) | (_) >  <   v1.18.0-SNAPSHOT-b2176
 |____/ \___|_| |_|\__\___/|____/ \___/_/\_\  Loaded in 13417ms.

[22:17:03 INFO]: [BentoBox] Added world CaveBlock (HARD)
[22:17:03 INFO]: Done (15.532s)! For help, type "help"
[22:17:03 INFO]: Timings Reset
[22:17:03 INFO]: [BentoBox] Loaded Blueprint Bundle 'miner-cave' for CaveBlock.
[22:17:03 INFO]: [BentoBox] Loaded Blueprint Bundle 'default' for CaveBlock.
[22:17:03 INFO]: [BentoBox] Downloading data from GitHub...
[22:17:03 INFO]: [BentoBox] Updating the Catalog...
[22:17:03 INFO]: [BentoBox] Loaded blueprint 'nether-cave' for CaveBlock
[22:17:04 INFO]: [BentoBox] Loaded blueprint 'cave' for CaveBlock
[22:17:04 INFO]: [BentoBox] Loaded blueprint 'end-cave' for CaveBlock
[22:17:04 INFO]: [BentoBox] Loaded blueprint 'miners-cave' for CaveBlock
[22:17:04 INFO]: [BentoBox] All blueprints loaded.
[22:17:06 INFO]: [BentoBox] Updating Contributors information...
[22:17:06 INFO]: [BentoBox] Gathering contribution data for: BentoBoxWorld/BentoBox, BentoBoxWorld/CaveBlock
[22:17:08 INFO]: [BentoBox] Successfully downloaded data from GitHub.
[22:18:45 INFO]: com.mojang.authlib.GameProfile@2a2b7df6[id=<null>,name=tastybento,properties={},legacy=false] (/127.0.0.1:57719) lost connection: Disconnected
[22:18:51 INFO]: UUID of player tastybento is 5988eecd-1dcd-4080-a843-785b62419abb
[22:18:51 INFO]: tastybento joined the game
[22:18:51 INFO]: tastybento[/127.0.0.1:57720] logged in with entity id 159 at ([world]82.5, 80.0, 108.5)
[22:19:15 INFO]: tastybento issued server command: /cb
[22:20:02 INFO]: tastybento lost connection: Disconnected
[22:20:02 INFO]: tastybento left the game
> bbox v
[22:22:21 INFO]: Running PAPER 1.17.1.
[22:22:21 INFO]: BentoBox version: 1.18.0-SNAPSHOT-b2176
[22:22:21 INFO]: Database: JSON
[22:22:21 INFO]: Loaded Game Worlds:
[22:22:21 INFO]: caveblock-world (CaveBlock): Overworld, Nether, The End
[22:22:21 INFO]: Loaded Addons:
[22:22:21 INFO]: CaveBlock 1.15.0-SNAPSHOT-b406 (ENABLED)
tastybento commented 3 years ago

Just to be clear, although BentoBox and CaveBlock call the generation, the stack goes way into the depths of the server code before throwing the error, so this seems like a server error of some kind. I'd recommend you just try it again and maybe in a few Paper builds there will be a fix.