Minor changes to median splitting

Bersaelor / KDTree

Swift implementation of a k-dimensional binary space partitioning tree.

MIT License

153 stars 26 forks source link

Minor changes to median splitting #22

Closed aplusm closed 7 years ago

aplusm commented 7 years ago

Ensure left subtree contains currentSplittingDimension-coordinate strictly less than its parent node. This fix is needed for 'contains' and 'removing' method.

Bersaelor commented 7 years ago

@aplusm I also realized it's your first github PR. Congratz!

If you need any help with the unit tests, please just ask :)

aplusm commented 7 years ago

Thank you @Bersaelor !

You're right ! 20 years of coding and this is actually my first github PR..;) I wrote unit test and will be push it tonight..

Bersaelor commented 7 years ago

@aplusm About running the tests locally: Test Targets are usually associated with a framework or example target. I choose the iOS or OSX example (KDTree_Example, KDTree_OSX_Example) and press 'Cmd+U'. You can also longpress the play-icon in xcode and choose the test-icon there.