search

BetterErrors / better_errors

Better error page for Rack apps
MIT License
6.88k stars 435 forks source link

Make sassc a runtime dependency #515

Closed leoarnold closed 1 year ago

leoarnold commented 1 year ago

After upgrading better_errors from v2.9.1 to v2.10.0 our Rails app would not boot anymore in development mode. The reason is that error_page_style.rb requires sassc which was not installed, as it was not marked as a runtime dependency.

Fixes #516

tagliala commented 1 year ago

Same here, but please do not add sassc as a runtime dependency.

It requires a lot of time to build and it is not necessary in modern Rails based on JS build systems. Please consider to pre-build the css

Physium commented 1 year ago

what the reason for this PR not merging?

leoarnold commented 1 year ago

@Physium The maintainer probably did not have time yet to consider this PR.

RobinDaugherty commented 1 year ago

Thank you for the change @leoarnold, but the intention is specifically to not have sassc as a runtime dependency. (Explained in #498.) #520 should fix this issue, and I hope to release that soon.