search

BigNoid / script.skinshortcuts

GNU General Public License v2.0
23 stars 69 forks source link

Build empty templates if not matched #151

Closed ghost closed 8 years ago

ghost commented 8 years ago

As discussed in #142 this writes empty includes for any template that isn't built by matching to menu items, avoiding any Skin Has Invalid Includes errors in log.

@marcelveldt hope you don't mind that I went ahead and wrote this, but there are more skins switching to templates so it would be nice to get this feature onto the repo sooner than later. Are you happy with the way I've implemented it?

Closes #142

marcelveldt commented 8 years ago

haha, you've beaten me to it. Was going to take a look at it one of these days ;-) Code looking fine, no problems merging this in. Thanks!

ghost commented 8 years ago

Cheers. How do you feel, when we know whether #149 is going in, doing a repo push so that the skins adopting templates won't have problems with the mailing list (and so the mailing list find it easier, of course)?

Only one new feature, the rest bug fixes so if a beta period is needed it shouldn't need to be a long one!

marcelveldt commented 8 years ago

A repo push sounds good to me. Want to do it now or first revert the temp krypton code ?

ghost commented 8 years ago

My reading right of Phil's PR means that the Krypton change won't be necessary, so I say get the reversion in and - if necessary - it can be un-reverted later.

I'd also say get getting-rid of the music library visibility conditions in too. Are you happy doing that?

marcelveldt commented 8 years ago

OK, sounds great. I will fix the music visibility then and afterwads we can do another repo pull