Use Krypton inbuilt select dialog

BigNoid / script.skinshortcuts

GNU General Public License v2.0

23 stars 69 forks source link

Use Krypton inbuilt select dialog #199

Closed ghost closed 8 years ago

ghost commented 8 years ago

Updates the select dialog calls which display an icon along with the item (internally referred to as the 'pretty' select dialog) to use the new useDetails=True call introduced with Krypton.

@marcelveldt I have tested this locally, but I'm still restoring my system after an epic juice-related hardware failure so I wouldn't class my tests as definitive. Are you in a position to test + review this before it's merged?

marcelveldt commented 8 years ago

Don't know if you have access to my codacy details but there were spotted a few small issues with the PR... See screenshot

ghost commented 8 years ago

Liking the codacy :)

Unfortunately it's highlighting something I missed entirely whilst coding this, which is that we can't (seem) to use the 'Get More...' button in the select dialog with the new method. I'm going to close this for now until I think about how to deal with this.

Cheers

phil65 commented 8 years ago

I would stay with your old method until we implement a proper way to deal with the "get more..." button. I can take a look at that (shouldnt be that hard to implement), but that´s for v18 then..

phil65 commented 8 years ago

Btw most codacy errors should also get recognized by some of the common Python linters out there. ;)

ghost commented 8 years ago

And when I've got this system fully re-installed (so I'm not just coding in notepad whilst I await the replacement hdd) I'll get back to having proper debug tools :) Cheers Phil, anything you could do for the Get More would be great.