Bigfoot71 / raymob

Simple raylib implementation for Android
Other
85 stars 19 forks source link

Error when changing package name. #7

Closed KorotkiyKamil closed 12 months ago

KorotkiyKamil commented 1 year ago

Change app.name and projectName works. app.application_id does not change. app.application_id=com.raylib.raymob it works. Android gradle plugin version 8.0.2 Gradle version 8.0

Or am I changing it in the wrong place?

Снимок экрана 2023-12-01 183908

Bigfoot71 commented 1 year ago

@KorotkiyKamil Indeed, I apologize for the inconvenience. It's due to the addition of new features that haven't been fully tested...

I have just committed a fix for this issue (https://github.com/Bigfoot71/Raymob/commit/a79f6e575adfa83625c41122223379319b9dbbf0). Could you please let me know if the current master branch resolves your issues?

Edit: Sorry for the duplication, I wanted to go fast, my bad, hehe

KorotkiyKamil commented 12 months ago

Now it works, but the package name only changes in BuildConfig.java. But NativeLoader it remains so package com.raylib.raymob; // Don't change the package name (see gradle.properties) The error warning does not interfere with the build. Снимок экрана 2023-12-02 041411 Снимок экрана 2023-12-02 041502

Bigfoot71 commented 12 months ago

@KorotkiyKamil Yes, that's normal. The name change occurs during compilation so that your APK/AAB has the requested package name. Afterward, the project is "reset".

It's the simplest way for the user (and causes the fewest diverse issues) that I've found to centralize project configuration in a single file. (Assuming it's well-maintained...)

If the APK has the correct name, version, and requested features, and everything resets correctly in the raymob code (meaning you can recompile again while changing names as needed), then you can consider everything to be working.

Edit: Otherwise what "error warning" are you talking about? I don't see any errors in your captures

Ah yes sorry, about BuildConfig, it's just that BuildConfig is generated automatically during your project's build, and the package name it contains obviously doesn't match the default name used by raymob (which is reset in a post-compilation task). However, since your project parameters are configured before the build (or rather, it's part of the initial tasks before generating BuildConfig), it's not a problem. BuildConfig will also be automatically regenerated if needed, so no need to worry.

In a typical use of raymob, you should mainly work with C or C++. Java will only be necessary for specific needs, so you can completely ignore these details.

If you no longer have any issues regarding this, you can close the issue, and feel free to reopen it if you have any questions or encounter another problem.

KorotkiyKamil commented 12 months ago

Ok. Thank you.