search

BimmerGestalt / AAIdrive

Implementations of some Android Auto features as unofficial IDrive apps
MIT License
556 stars 92 forks source link

Add brand specific icons for the Vehicle Info app #802

Closed superwofy closed 3 months ago

superwofy commented 4 months ago

I added a simple brand check for the Detailed Vehicle Info icon.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.42%. Comparing base (c63c9e6) to head (4518f04). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/802/graphs/tree.svg?width=650&height=150&src=pr&token=CbUKVyqYmJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt)](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/802?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt) ```diff @@ Coverage Diff @@ ## main #802 +/- ## ============================================ + Coverage 41.16% 42.42% +1.26% + Complexity 1519 1516 -3 ============================================ Files 262 255 -7 Lines 12755 12317 -438 Branches 2525 2460 -65 ============================================ - Hits 5250 5226 -24 + Misses 6392 5989 -403 + Partials 1113 1102 -11 ``` | [Files](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/802?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt) | Coverage Δ | | |---|---|---| | [...droidautoidrive/carapp/notifications/ReadoutApp.kt](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/802?src=pr&el=tree&filepath=app%2Fsrc%2Fmain%2Fjava%2Fme%2Fhufman%2Fandroidautoidrive%2Fcarapp%2Fnotifications%2FReadoutApp.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt#diff-YXBwL3NyYy9tYWluL2phdmEvbWUvaHVmbWFuL2FuZHJvaWRhdXRvaWRyaXZlL2NhcmFwcC9ub3RpZmljYXRpb25zL1JlYWRvdXRBcHAua3Q=) | `57.79% <0.00%> (-1.09%)` | :arrow_down: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/802/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/802?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/802?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt). Last update [c63c9e6...4518f04](https://app.codecov.io/gh/BimmerGestalt/AAIdrive/pull/802?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BimmerGestalt).
hufman commented 4 months ago

Nifty! Would it be possible to add the SVG source for the sedan icon too, or where did it come from?

superwofy commented 3 months ago

Nifty! Would it be possible to add the SVG source for the sedan icon too, or where did it come from?

Sure, added.

hufman commented 3 months ago

Nifty, thank you so much!