search

BimmerGestalt / AAIdrive

Implementations of some Android Auto features as unofficial IDrive apps
MIT License
556 stars 92 forks source link

Add build variant toggle for custom resources #804

Closed superwofy closed 3 months ago

superwofy commented 3 months ago

This will allow anyone using the libhmiremoting.so patch described here: https://github.com/BimmerGestalt/AAIdrive/discussions/801 to make modifications to RHMI resources.

hufman commented 3 months ago

external.gradle is just used to copy resources from the original APK files to the assets/carapplications directory, and doesn't influence what gets packaged in the final APK. Any files in the assets directory gets packaged, so you can add your own resources manually without needing to change external.gradle.

hufman commented 3 months ago

I think this feature is too small to need an additional variant dimension. Adding another variant adds another keyword to all the build step names, and would be required for custom manifests or if we wanted to ship different assets in different builds. I believe just a simple Gradle property would be fine for this usecase. Check out what I mean: https://github.com/BimmerGestalt/AAIdrive/compare/rhmi_custom_resources

superwofy commented 3 months ago

I think this feature is too small to need an additional variant dimension. Adding another variant adds another keyword to all the build step names, and would be required for custom manifests or if we wanted to ship different assets in different builds. I believe just a simple Gradle property would be fine for this usecase. Check out what I mean: https://github.com/BimmerGestalt/AAIdrive/compare/rhmi_custom_resources

Agreed, thank you.