BinarMorker / TimeWastedOnDestiny

http://wastedondestiny.com
GNU General Public License v3.0
23 stars 3 forks source link

Username used to show up now it doesn't. #36

Closed lejohnduke closed 7 years ago

lejohnduke commented 7 years ago

basically what the title says my xbox gamertag used to work on this site when i searched but now i don't get any result

BinarMorker commented 7 years ago

What is your username?

On Wed, May 17, 2017 at 3:15 AM, lejohnduke notifications@github.com wrote:

basically what the title says my xbox gamertag used to work on this site when i searched but now i don't get any result

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BinarMorker/TimeWastedOnDestiny/issues/36, or mute the thread https://github.com/notifications/unsubscribe-auth/AFh1qutrNhIoa2L2Olvr-KNkILO60q0Aks5r6p6RgaJpZM4Nddk8 .

lejohnduke commented 7 years ago

lejohnduke For Both consoles

BinarMorker commented 7 years ago

The issue should now be fixed. Please confirm.

lejohnduke commented 7 years ago

still not working

BinarMorker commented 7 years ago

Alright, there has been a regression on the production environment. I'll keep you informed when I'm able to update my website properly.

On Thu, May 18, 2017 at 11:28 PM, lejohnduke notifications@github.com wrote:

still not working

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BinarMorker/TimeWastedOnDestiny/issues/36#issuecomment-302599473, or mute the thread https://github.com/notifications/unsubscribe-auth/AFh1qoDn5okeb-1TBun0QEFHK0YKx1x4ks5r7QxhgaJpZM4Nddk8 .

Youmy001 commented 7 years ago

I looked as the issue and as @BinarMorker said it works, but it only works on the API as shown over here (https://www.wastedondestiny.com/api/?console=1&user=lejohnduke). However, there is an error while trying to load the information on the website.

The error thrown is a "Cannot read property 'forEach' of undefined" on line 74 of viewmodel.js. Althought @lejohnduke have an account for PS4, he might have never created a character on that account in Destiny. @BinarMorker, you should verify characters exists in self.player().playstation and self.player().xbox beforre looping inside them.

BinarMorker commented 7 years ago

I figured this out already and corrected the issue. However, I could not deploy yet.

On Fri, May 19, 2017 at 9:12 AM, Tommy Teasdale notifications@github.com wrote:

I looked as the issue and as @BinarMorker https://github.com/binarmorker said it works, but it only works on the API as shown over here ( https://www.wastedondestiny.com/api/?console=1&user=lejohnduke). However, there is an error while trying to load the information on the website.

The error thrown is a "Cannot read property 'forEach' of undefined" on line 74 of viewmodel.js. Althought @lejohnduke https://github.com/lejohnduke have an account for PS4, he might have never created a character on that account in Destiny. @BinarMorker https://github.com/binarmorker, you should verify characters exists in self.player().playstation and self.player().xbox beforre looping inside them.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BinarMorker/TimeWastedOnDestiny/issues/36#issuecomment-302699065, or mute the thread https://github.com/notifications/unsubscribe-auth/AFh1qlJBc6gAT8agLFSfPzGXBUEBTOmkks5r7ZU5gaJpZM4Nddk8 .

BinarMorker commented 7 years ago

A fix has been deployed.

lejohnduke commented 7 years ago

thank you all for your help!