Fixes failing PowerPC unit tests

BinaryAnalysisPlatform / bap

Binary Analysis Platform

MIT License

2.07k stars 273 forks source link

Fixes failing PowerPC unit tests #1603

Open bmourad01 opened 5 months ago

bmourad01 commented 5 months ago

The failing tests were all related to load/store instruction encodings. It seems that they accept a sign-extended 16-bit immediate offset in these cases, and the sign extension wasn't being performed by the lifter.

bmourad01 commented 5 months ago

cc @gitoleg The git history says you wrote all of this so I wanted to make sure that these changes make sense. I assume at one point the tests were passing.

gitoleg commented 5 months ago

@bmourad01

looks reasonable! But I have no idea why we didn't see this fail before