Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.53k stars 290 forks source link

Terminal colours seem off #382

Closed FredHappyface closed 4 years ago

FredHappyface commented 4 years ago

This may be a largely personal thing (to me that is) but the terminal colours seem off compared to other one dark terminal themes such as the konsole theme

VsCode:

image image

Konsole:

image image

Would like to add what a great project this is :smile:

Binaryify commented 4 years ago

I don't know how to reproduce it, could you provide some way? image

FredHappyface commented 4 years ago

Here is some code that produces the output below:

Powershell

Write-Output "$([char]27)[35mMagenta$([char]27)[00m|$([char]27)[95mBrightMagenta$([char]27)[00m" 

Bash

echo -e '\033[35mMagenta\033[00m|\033[95mBrightMagenta\033[00m'

And here is the actual output: image

^ This is using the Base24 OneDark theme

Binaryify commented 4 years ago

i see, will improve that

Binaryify commented 4 years ago

will use your terminal color config, I think you did a good job

FredHappyface commented 4 years ago

Thank you. I'll drop a copy of the colours here

Order is red, yellow, green, cyan, blue, purple followed by bright

base08: "e05561"
base09: "d18f52"
base0B: "8cc265"
base0C: "42b3c2"
base0D: "4aa5f0"
base0E: "c162de"
base12: "ff616e"
base13: "f0a45d"
base14: "a5e075"
base15: "4cd1e0"
base16: "4dc4ff"
base17: "de73ff"

Hope this helps 😊

Binaryify commented 4 years ago

just publish a new version, you can check it later

FredHappyface commented 4 years ago

That's great. Thank you! 😄