Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

(inactive) Ribostan #2448

Closed zslastman closed 3 weeks ago

zslastman commented 2 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 2 years ago

Hi @zslastman

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: Ribostan
Title: Estimates Isoform Specific RPF Footprint Densities
Version: 0.99.0
Authors@R: 
    person(given = "Dermot",
 family = "Harentt",
 role = c("aut", "cre"),
 email = "dermot.harnett@mdc-berlin.de",
 comment = c(github = "www.github.com/zslastman"))
Maintainers@R: 
    person(given = "Dermot",
 family = "Harentt",
 role = c("aut", "cre"),
 email = "dermot.harnett@mdc-berlin.de",
 comment = c(github = "www.github.com/zslastman"))
Description: Ribostan is a simple package which contains functionality related
  to ribosomal footprint data and quantitative analysis thereof. It includes
  functions to align A/P sites by maximizing including in the CDS, to produce
  plots of KL divergence in 'metacodon' plots, and to estimate Ribosomal Footprint
  densities in an isoform aware manner. It also provides functions for quantifying
  periodicity of open reading frames, and identifying translated uORFs.
License: `use_mit_license()`, `use_gpl3_license()` or friends to
    pick a license
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.2
VignetteBuilder: knitr
Config/testthat/edition: 3
biocViews: RiboSeq, Sequencing, QualityControl, DataImport, GenomeAnnotation,
  Transcriptomics, Software, Coverage, RNASeq
Suggests:
    here,
    knitr,
    rmarkdown,
    BSgenome.Hsapiens.UCSC.hg38,
    AnnotationHub,
    BiocStyle,
Imports:
    rtracklayer,
    rstan,
    Matrix,
    ggplot2,
    Rsamtools,
    BiocGenerics,
    Biostrings,
    testthat,
    GenomicFeatures,
    GenomicAlignments,
    GenomeInfoDb,
    GenomicFiles,
    GenomicRanges,
    IRanges,
    S4Vectors,
    readr,
    stringr,
    dplyr,
    multitaper,
    tidyr,
    magrittr,
    ORFik,
    broom,
    tibble,
Depends:
    R (>= 4.0.0)
vjcitn commented 2 years ago

see https://github.com/zslastman/RiboStan/issues/2 -- can't even build with current R/Bioc

zslastman commented 2 years ago

Hi, sorry about that! I will be able to give this my focus again tuesday next week, will fix the licence issues and confirm it builds on my own machine, with the most recent bioc docker image.

On Tue, Dec 14, 2021, 2:39 PM Vince Carey @.***> wrote:

see zslastman/RiboStan#2 https://github.com/zslastman/RiboStan/issues/2 -- can't even build with current R/Bioc

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/2448#issuecomment-993553157, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ3ENU6GX7ALJMVK7TMELLUQ5CJNANCNFSM5JWDHS7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

vjcitn commented 2 years ago

Hi any updates here?

zslastman commented 2 years ago

Hi! Sorry for the long delay. Changing jobs and address during the pandemic has taken up my time this past month. I'll be able to push again within two weeks.

lshep commented 2 years ago

@zslastman if you do not have time to work on the submission we can close the issue for inactivity and you can request it be opened again once your time allows.

zslastman commented 2 years ago

Sorry for the delay guys, I'm available to work on the package again now.

https://github.com/zslastman/RiboStan/issues/2 is fixed

Can you let me know how to go about setting up a build environment that's identical to the one used by Bioconductor? My current understanding is that I want to load the most recent docker image and then run R CMD build, but I notice this doesn't work on e.g. the DESeq2 source code, (it fails because the vignette dependency rmarkdown isn't installed). So I must not have it right.

vjcitn commented 2 years ago

How to "set[...] up a build environment that's identical to the one used by Bioconductor" is pretty much an open question at this time. We are working on github action templates that should eventually accomplish this. You are welcome to discuss the issue further on bioc-devel mailing list, detailing your expectations and efforts. I am working on pre-checks for your package now.

vjcitn commented 2 years ago

Did you run R CMD check on your package source tarball before pushing? Do so with version bumps for every source code change. With

commit 8d233ee11231f88ef069693ba1cbc18c3c3446f3
Author: Dermot Harnett <zslastman@gmail.com>
Date:   Thu Feb 17 14:47:25 2022 -0500

    GRlists not imported

I am getting

--- re-building ‘Ribostan.rmd’ using rmarkdown
Quitting from lines 71-76 (Ribostan.rmd) 
Error: processing vignette 'Ribostan.rmd' failed with diagnostics:
length(tokeep) > 0 is not TRUE
--- failed re-building ‘Ribostan.rmd’
vjcitn commented 2 years ago

Even INSTALL is noisy

PC002284:SUBMISSIONS vincentcarey$ R CMD INSTALL Ribostan
1/11 packages newly attached/loaded, see sessionInfo() for details.
* installing to library '/Users/vincentcarey/R-dev-dist/lib/R/library'
* installing *source* package 'Ribostan' ...
** using staged installation
** R
** data
** inst
** byte-compile and prepare package for lazy loading
1/11 packages newly attached/loaded, see sessionInfo() for details.
Note: wrong number of arguments to 'sqrt' 
Note: wrong number of arguments to '==' 
Note: wrong number of arguments to '>' 
Note: wrong number of arguments to '>' 
Note: wrong number of arguments to '==' 
Note: wrong number of arguments to '==' 
Note: wrong number of arguments to '>' 
Note: wrong number of arguments to '/' 
** help
*** installing help indices
** building package indices
1/11 packages newly attached/loaded, see sessionInfo() for details.
** installing vignettes
** testing if installed package can be loaded from temporary location
1/11 packages newly attached/loaded, see sessionInfo() for details.
** testing if installed package can be loaded from final location
1/11 packages newly attached/loaded, see sessionInfo() for details.
** testing if installed package keeps a record of temporary installation path
* DONE (Ribostan)
vjcitn commented 2 years ago

I am going to let it go into the build/check process for review.

zslastman commented 2 years ago

Okay, thanks Vincent, and sorry no I wasn't running check on the tarball. I'd been using devtools::check, but will switch to tarball + R CLI.

What is the correct method of specifying dependencies and then building such that all dependencies are installed? Again I had been using devtools but I guess this isn't bioconductor koshure. Should I simply assume that all dependencies, including e.g. BiocStyle for the vignettes, are present on the system I"m building on?

vjcitn commented 2 years ago

Good questions. We endeavor to answer these on the developer guidelines so if those are not sufficiently clear please pose questions at bioc-devel. We have automated the derivation of dependencies on R packages so you can assume all packages from CRAN or Bioconductor that are imported or suggested or depended upon or enhancing are available. Packages outside these two regulated environments cannot be used at all. As for system dependencies like runtime libraries the SystemRequirements field in DESCRIPTION should be used. I don't think there's a standard syntax/vocabulary for those requirements yet. @lshep @jwokaty

bioc-issue-bot commented 2 years ago

A reviewer has been assigned to your package. Learn what to expect during the review process.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org access. To manage keys and future access you may want to active your Bioconductor Git Credentials Account

bioc-issue-bot commented 2 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR, skipped". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/Ribostan to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

ococrook commented 2 years ago

@zslastman, Could you remove the ERRORs in the build report, I can start reviewing the package once that's complete

zslastman commented 2 years ago

Yes, apologies, only get them myself when I installed on a fresh system.

Also removing the non-standard evaluation from the dplyr functions to clean up the build report.

lshep commented 2 years ago

@zslastman may we expect updates soon? We like to see progress within a 3-4 week time frame of leaving comments and feedback? If you have an updated version to clean up the ERRORs please remember to activate your GitCredentials account https://git.bioconductor.org/BiocCredentials and push the update to git.bioconductor.org with a valid version bump to trigger a new build as described http://contributions.bioconductor.org/git-version-control.html#new-package-workflow

zslastman commented 2 years ago

Hi Ishep. Yes, sorry for the delay. I'll update by next weekend at the latest.

bioc-issue-bot commented 2 years ago

This issue is being closed because there has been no progress for an extended period of time. You may reopen the issue when you have the time to actively participate in the review / submission process. Please also keep in mind that a package accepted to Bioconductor requires a commitment on your part to ongoing maintenance.

Thank you for your interest in Bioconductor.

ggvillamil commented 10 months ago

Hi! Ownership of the repository for this package has been transferred to https://github.com/ohlerlab/RiboStan. We would like to resume the submission process. Is it possible to re-open this issue?

lshep commented 10 months ago

Should maintainer access still be @zslastman or does this need to be updated ? FWIW there is not Maintainer@R official field; Specifying "Cre" in Authors@R designates the maintainer.

zslastman commented 10 months ago

You should update the maintainer, Gabe will take over.

On Wed, Nov 8, 2023 at 8:48 AM lshep @.***> wrote:

Should maintainer access still be @zslastman https://github.com/zslastman or does this need to be updated ? FWIW there is not @. official field; Specifying "Cre" in @. designates the maintainer.

— Reply to this email directly, view it on GitHub https://github.com/Bioconductor/Contributions/issues/2448#issuecomment-1801926800, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ3ENXCG3GYBFMUJBUT5EDYDOET5AVCNFSM5JWDHS72U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBQGE4TENRYGAYA . You are receiving this because you were mentioned.Message ID: @.***>

ggvillamil commented 10 months ago

As @zslastman said, I will take over as maintainer. I am Gabe. :)

lshep commented 9 months ago

@ggvillamil do you have a BiocCredentials account; it doesn't look like it? If not I can set one up for you. what would be the best email to use?

bioc-issue-bot commented 9 months ago

Dear @zslastman ,

We have reopened the issue to continue the review process. Please remember to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot commented 9 months ago

A reviewer has been assigned to your package for an indepth review. Please respond accordingly to any further comments from the reviewer.

ggvillamil commented 9 months ago

Hi @lshep. Thanks for the assistance! I don't have an account yet. My email address is gabriel.villamil@mdc-berlin.de.

lshep commented 9 months ago

We have updated the credentials on our side. I will be sending you an email for how to activate your BiocCredentials account to add ssh keys for access

lshep commented 9 months ago

@ggvillamil this should have been taken care of. You should push to git.bioconductor.org to trigger a build report to proceed.

LiNk-NY commented 9 months ago

Is Oliver @ococrook still taking a look at this? Thanks!

lshep commented 9 months ago

@LiNk-NY sorry about that; I'll check the code that should prevent a reassignment if a reviewer is already assigned if reopened.

ggvillamil commented 9 months ago

Hi @lshep. I added an ssh key to my profile and was prompted that it was successfully added. However, my profile does not show any ssh keys and the list of packages I have access to is empty.

lshep commented 9 months ago

I see your account is active but also see no ssky keys added. Did you save the profile at the bottom once you added the key?

ggvillamil commented 9 months ago

Yes, I click the submit button and get the message: "New SSH Key for 'gabriel.villamil@mdc-berlin.de' was successfully added. An email confirmation of the change will not be sent. The updated information will be displayed in your User Profile."

But there are no ssh keys when I check my profile.

lshep commented 9 months ago

Can you please try again? This is rather odd as it is not occurring with anyone else. Another work around would be to add the ssh key to your github account as keys are also automatically pulled from there.

ococrook commented 9 months ago

Ill review this once a build is triggered. Thanks

ggvillamil commented 9 months ago

It is still happening unfortunately. Does it matter what kind of SSH key I am submitting? Right now I am submitting an ED25519 key.

I also noticed that the SSH key I have in my Github account is not being automatically pulled. I have had it from before I activated my BiocCredentials account as I generally use SSH to push to Github.

ggvillamil commented 9 months ago

Would it make sense to try re-making the BiocCredentials acount?

lshep commented 9 months ago

Since no one else seems to be having issues, yes that is probably the best option. I can try that now. Give me a few minutes to reset. I'll email you with a password to activate the new account.

bioc-issue-bot commented 9 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 51d201aee3552b9459e553f036a4e2d791f98638

bioc-issue-bot commented 9 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/Ribostan to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 9 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 733b3ca474e398b4a96328ada0c1ca3b0e9fd913

bioc-issue-bot commented 9 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: Linux (Ubuntu 22.04.2 LTS): Ribostan_0.99.2.tar.gz macOS 12.7.1 Monterey: Ribostan_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/Ribostan to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 8 months ago

Do you plan on submitting more change to fix the ERROR's, Warnings, and Notes that were occurring?

ggvillamil commented 8 months ago

Apologies for the delay. Will push some changes tomorrow.

bioc-issue-bot commented 8 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: b920344f88bbcc2186da1c733cb8a941b040827b

bioc-issue-bot commented 8 months ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder: macOS 12.7.1 Monterey: Ribostan_0.99.4.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/Ribostan to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

lshep commented 7 months ago

It also has been brought to our attention you have an invalid field in your DESCRIPTION. Please remove Maintainers@R as there is no such field. Authors@R is sufficient; using "cre" in Authors@R designates the maintainer.

bioc-issue-bot commented 7 months ago

Received a valid push on git.bioconductor.org; starting a build for commit id: a85139a8f58f69d6f62e3a37c4460b8d7705e159