Bioconductor / Contributions

Contribute Packages to Bioconductor
135 stars 33 forks source link

MACPET #538

Closed IoannisVardaxis closed 6 years ago

IoannisVardaxis commented 7 years ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For help with submitting your package, please subscribe and post questions to the bioc-devel mailing list.

bioc-issue-bot commented 7 years ago

Hi @IoannisVardaxis

Thanks for submitting your package. We are taking a quick look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: MACPET
Type: Package
Title: Model based analysis for ChIA-PET data
Version: 0.99.0
Date: 2017-25-10
Author: Ioannis Vardaxis
Maintainer: Ioannis Vardaxis <ioannis.vardaxis@ntnu.no>
Description: The MACPET package can be used for binding site analysis for ChIA-PET data. MACPET reads ChIA-PET data in BAM or SAM format and separates the data into Self-ligated, Intra- and Inter-chromosomal PETs. Furthermore, MACPET breaks the genome into regions and applies 2D mixture models for identifying candidate peaks/binding sites using skewed generalized students-t distributions (SGT). It then uses a local poisson model for finding significant binding sites. MACPET is mainly written in C++, and it supports the BiocParallel package.
License: GPL-3
Encoding: UTF-8
LazyData: true
ByteCompile: true
RoxygenNote: 6.0.1
biocViews: Software, DNA3DStructure, PeakDetection, StatisticalMethod, Bayesian, Clustering, Classification, HiC
Depends: R (>= 3.4.2), InteractionSet (>= 1.4.0)
Imports: intervals (>= 0.15.1), plyr (>= 1.8.4),  Rsamtools (>= 1.28.0), stats (>= 3.4.2), utils (>= 3.4.2), methods (>= 3.4.2), GenomicRanges (>= 1.28.6), S4Vectors (>= 0.14.7), IRanges (>= 2.10.5), GenomeInfoDb (>= 1.12.3), gtools (>= 3.5.0), GenomicAlignments (>= 1.12.2), BSgenome (>= 1.44.2), knitr (>= 1.17), Rcpp (>= 0.12.13), rtracklayer (>= 1.36.6), BiocParallel (>= 1.10.1)
Suggests: ggplot2 (>= 2.2.1), igraph (>= 1.1.2), rmarkdown (>= 1.6.0.9004), reshape2 (>= 1.4.2), BiocStyle (>= 2.4.1)
VignetteBuilder: knitr
RdMacros: Rdpack
LinkingTo: Rcpp
Collate: 
    'ALLData.R'
    'AllClasses.R'
    'AnalysisStatistics.R'
    'ConvertToPSelf-methods.R'
    'InputChecks.R'
    'MACPET_pkg.R'
    'PeakCallerUlt.R'
    'PeaksToGRanges-methods.R'
    'PeaksToNarrowPeak-methods.R'
    'RcppExports.R'
    'Stage_0_PETClassificationFunctions.R'
    'Stage_1_PeakFinderFunctions_R.R'
    'TagsToGInteractions-methods.R'
    'exportPeaks-methods.R'
    'plot-methods.R'
    'summary-methods.R'
bioc-issue-bot commented 7 years ago

Your package has been approved for building. Your package is now submitted to our queue.

IMPORTANT: Please read the instructions for setting up a push hook on your repository, or further changes to your repository will NOT trigger a new build.

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS, skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/MACPET_buildreport_20171026041125.html

IoannisVardaxis commented 7 years ago

Hey,

Should I ask questions here on bioc-devel@r-project.org?

I am trying here first.

I have set up a push hook on your repository I think. I did what is on the instructions. (sorry i havent done this before and it takes time to understand.)

I have some questions for the errors I got, because I dont get any when I build or check the package on my MAC.

On the build report it says that "unknown macro '\insertRef'" somewhere at the beginning. I include a reference file for an article, how can I avoid this warning? I am not aware of any other macro to include references in roxygene.

A little further down I get an error " error: round is not a member of std", I didnt have any such error before in the algorithm and no problems with std for c++ in general. However I checked again now and for functions for std::log, std::round and std::ceil I get error that the "the call to function is ambigious". the header of my c++ script is:

include

using namespace Rcpp;

Should I change that somehow?

Finally, when I make all the changes locally at my MAC and then push the changes, will this automatically update the package and trigger a new check or do I need to do something more?

Thanks for all your held and time!

nturaga commented 7 years ago

Hi bioc-devel is better venue for this.

IoannisVardaxis commented 7 years ago

Thanks :)

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

037f544 Updated version from 0.99.0 to 0.99.1 because I fo...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR, WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/MACPET_buildreport_20171027135637.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

21a0005 Updating version from 0.99.1 to 0.99.2 60c7bcf Updating the temporary file for the examples.

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/MACPET_buildreport_20171027154603.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

5e202cb Removing the Rdpack package and updating version t...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/MACPET_buildreport_20171027164238.html

IoannisVardaxis commented 7 years ago

Hey,

Now that the package is at stage 2. progress, should I do anything or just wait for a response?

nturaga commented 7 years ago

HI @IoannisVardaxis I will review your package this week and post a review.

IoannisVardaxis commented 7 years ago

Ok!

Thanks:)

Ioannis Vardaxis Stipendiat NTNU Sendt fra min iPhone

  1. okt. 2017 kl. 14:25 skrev Nitesh Turaga notifications@github.com<mailto:notifications@github.com>:

HI @IoannisVardaxishttps://github.com/ioannisvardaxis I will review your package this week and post a review.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Bioconductor/Contributions/issues/538#issuecomment-340539430, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AWOL_5t2l1hVIwkvqoi-X3c1nCS8AiEKks5sxhSogaJpZM4QG77p.

IoannisVardaxis commented 7 years ago

Hi @nturaga , have you checked the package?

nturaga commented 7 years ago

Your review will be posted by tomorrow.

IoannisVardaxis commented 7 years ago

How is it going with the review?

nturaga commented 7 years ago

MACPET_review

Build and Install

DESCRIPTION

NAMESPACE

man

vignette

Quitting from lines 393-401 (MACPET.Rmd)
Error: processing vignette 'MACPET.Rmd' failed with diagnostics:
GenomePkg is not installed! See ??BSgenome::installed.genomes
Execution halted

The problem with this error, is it doesn't tell me what package is missing but instead says GenomePkg.

R

Use message() instead of cat() so that diagnostic messages go to stderr rather than stdout, if that is your intention.

You don't need cat(paste(, you can just use cat. cat(rep("-",25),sep="") will work just fine. Using paste is not needed.

Same thing with return(cat("... and also stop(paste(... There is no need to use paste.

Do this throughout your code as there are multiple instances.

    stop("hitmap has to be logical!")
IoannisVardaxis commented 7 years ago

Thanks! I will push the new version as soon as i am done with the changes. What do you mean with : " indent your C++ code better to make it more readable" on the last point? Also, I would like to add something to the sysdata.rda, and this will update some Rd files. Is it ok to do it know?

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

10907ea Version update to 0.99.4 54d137d Adding "is" function from method package 013cfec Changes on R codes and reformating using formatR p... 65a7a68 Adding some new genomes for the black list. d487d04 Documenting the new genomes in sysdata.Rda. Also r... 5d6c727 Removing commented code. afe057a Adding more documentation to vignette. Also fixing...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/MACPET_buildreport_20171115084344.html

bioc-issue-bot commented 7 years ago

Received a valid push; starting a build. Commits are:

68df52c Updating R version to 3.5, also the MACPET version...

bioc-issue-bot commented 7 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/MACPET_buildreport_20171115085404.html

IoannisVardaxis commented 7 years ago

I made all the changes you suggested. For the vignette I wrote a little more, however I think everything is well explained. I can surely make more changes if you think that it is not enough.

IoannisVardaxis commented 7 years ago

Hi @nturaga , have you checked the latest push? I dont know if you have checked the c++ code yet, but I need to make some small changes to the code. Basically I need to add a small function, so the change is not big at all, but it is important.

Furthermore, the package takes as input a BAM or SAM file of the mapped sequences. The user himself has to map the fastq files and filter them using bowtie for example. I was thinking that since Bioconductor has packages for sequence mapping etc, maybe I could add them to the package to make it whole so the user does not need to refer to other algorithms prior using mine. Basically I will add another step to the whole analysis with a new R/c++ module for doing what i wrote above. Is it ok if I do it at this point?

nturaga commented 7 years ago

Yes, go ahead. I can only re-check your package after Nov 28th.

IoannisVardaxis commented 7 years ago

Perfect, you can wait until I send the next push. It might be after Nov 28th.

nturaga commented 6 years ago

Hi @IoannisVardaxis Please issue a version bump, so that your latest changes can build.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

6098a1f Renaming State 0 to Stage 2 and Stage 1 to Stage 3 909ce06 Renaming to MACPETUlt 16be1ef Renaming the data files 94cd103 Small changes to those functions and their Rmb fil... 549c115 Deleting old Rd files 46ebd48 Now C++ codes, the Stage_3 was there before, just ... 86f354b Changes in the vignette fc68ad9 Introducing new data and just chaning names in pre... ef54f30 Small changes to Rd files for the data 2de1d51 New function b15ea72 Updated names for the previous stages 0 and 1 8c8204c New stages 0 and 1 for mapping and filtering 7fe9ed9 New name for the PeakCaller, main function 9ae875d Update in the description and Namespace

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/MACPET_buildreport_20171212045825.html

IoannisVardaxis commented 6 years ago

Hey, I sent the new updates. I didnt change much on the old functions, but I made two new big scripts so the rest of the functions had to be updated a little. I also wrote more in the vignette, but I could write even more if you want.

nturaga commented 6 years ago

Updates

IoannisVardaxis commented 6 years ago

For the AnalysisStatistics I would prefer having it as cat because the function works as a summary, if I use message then everything will be in orange letters which I dont want. But It is not important for me so I could change it if you want.

The reason I used options(warn=-1) is that suppressWarnings() did not work. I would also like to avoid it. Maybe it has something to do with the R-devel, i dont know.

I was making the calls invisible because they return a directory, which I dont really need. I will remove them.

nturaga commented 6 years ago

@IoannisVardaxis When you are ready, please bump the version and let the package build again. I'll take that as a sign to review your package again.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

2062eca version bump 08be70c Updates and corrections

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the following build report for more details:

http://bioconductor.org/spb_reports/MACPET_buildreport_20171219105237.html

IoannisVardaxis commented 6 years ago

I made the updates except from the "futile.logger" which I couldnt figure out how to create a log file and how to write in it actually.

nturaga commented 6 years ago

Hi @IoannisVardaxis Did you take a look at this? https://cran.rstudio.com/web/packages/futile.logger/README.html

The section you want is flog.appender

To change the appenders assigned to a logger, use flog.appender():

# Change the 'quiet' logger to write to a file
flog.appender(appender.file('quiet.log'), 'quiet')
flog.warn("Goodbye, %s", "world", name='quiet')
bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

7f35561 version bump bdc07a2 Changes in log file

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "skipped, ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

0e7c9e2 Version bump

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

IoannisVardaxis commented 6 years ago

I made the changes with the "write" to "futile.logger". However I get an error when I push the new version:

It seems the error is in the lapply function all of a sudden. I dont get any error when I build the package on my MAC though. I tried to find what causes the error but I cant.

bioc-issue-bot commented 6 years ago

Received a valid push; starting a build. Commits are:

d568768 Version update and trying to fix the encoding erro...

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

IoannisVardaxis commented 6 years ago

I have been trying to find and fix the error I get with no success. I think the problem is with the encoding, however I havent changed anything like that. The problem came after i changed the write function with the futile.logger function but I dont understand if it that which causes the error.

IoannisVardaxis commented 6 years ago

Hi @nturaga , Can you please help me with the error so that I can send a valid push?

nturaga commented 6 years ago

Hi @IoannisVardaxis ,

This was an error on our end. We have issued a fix.

I would suggest a version bump for a new build tomorrow.

bioc-issue-bot commented 6 years ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.