Biogen-Inc / tidyCDISC

Demo the app here: https://bit.ly/tidyCDISC_app
https://biogen-inc.github.io/tidyCDISC/
GNU Affero General Public License v3.0
108 stars 38 forks source link

R script path object name issues when not using CDISC pilot data #198

Closed AARON-CLARK closed 1 year ago

AARON-CLARK commented 1 year ago
          @AARON-CLARK I'm going through the checklist, and I'll post my comments when I finish. But I just want to point out one issue I have found when using study data (not CDISC). The variables `filenames` and `file_names` are both being used, but I think they should be the same

The Shiny app code

https://github.com/Biogen-Inc/tidyCDISC/blob/71f0514823b5032fed1124d2d5619973ac4201dc/R/mod_tableGen.R#L745-L756

produces this script,

image

which gives an error because of the variable name:

image

There is the same issue with the variables study_dir and study_directory. The variable names should be the same:

image

Originally posted by @tdwils in https://github.com/Biogen-Inc/tidyCDISC/issues/172#issuecomment-1458843091

tdwils commented 1 year ago

@AARON-CLARK & @Jeff-Thompson12 I am testing the script generated by tidyCDISC, and I get an error when it tries to install the latest version of tidyCDISC:

>   remotes::install_github('Biogen-Inc/tidyCDISC')
Downloading GitHub repo Biogen-Inc/tidyCDISC@HEAD
Error in utils::download.file(url, path, method = method, quiet = quiet,  : 
  download from 'https://api.github.com/repos/Biogen-Inc/tidyCDISC/tarball/HEAD' failed

According to this: https://stackoverflow.com/questions/65421798/devtoolsinstall-github-failing-in-r4-0-03#:~:text=Turns%20out%20that%20this%20problem%20was%20caused%20by,is%20a%20default%2060%20second%20timeout%20for%20install_github. , the timeout needs to be increased.

Are you familiar with this?

Jeff-Thompson12 commented 1 year ago

According to this: https://stackoverflow.com/questions/65421798/devtoolsinstall-github-failing-in-r4-0-03#:~:text=Turns%20out%20that%20this%20problem%20was%20caused%20by,is%20a%20default%2060%20second%20timeout%20for%20install_github. , the timeout needs to be increased.

Are you familiar with this?

No, I have not come across this issue before.

tdwils commented 1 year ago

I am not getting the download error today, so it must have been heavy traffic yesterday.

AARON-CLARK commented 1 year ago

closed with #205