search

BiomedSciAI / fuse-med-ml

A python framework accelerating ML based discovery in the medical field by encouraging code reuse. Batteries included :)
Apache License 2.0
134 stars 34 forks source link

Pl model save + export the entire dataset (all keys) to dataframe #281

Closed mosheraboh closed 1 year ago

mosheraboh commented 1 year ago

Thanks for the review @SagiPolaczek ! Even though we talked answering here for future reference:

  1. the stored arguments are not useful in a common scenario (such as continue the training - cause you to run the exact same script anyway and recreate the arguments). model on the other hand is useful to load a model for inference.
  2. Yes, we need unittest. I will open an issue.
  3. since it's three lines, I'm not sure.
  4. I wanted to support the simplest building blocks in data pipeline (such as a function that gets sample_dict) and not to force all to inherit from OpBase.