search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.51k stars 216 forks source link

Indicate the user when something is wrong (monitors) #2477

Open yami-no-tusbas opened 3 years ago

yami-no-tusbas commented 3 years ago

Is your feature request related to a problem? Please describe

Recently I had an artist tag which got changed, something like baf to baffu The thing is, baffu has over 500 hundreds results, and baf, only five. And for grabber there is nothing wrong here, but for me the user, something went wrong.

Describe the solution you'd like

Can grabber notice when the result goes down ? Maybe using this :

[Info] [gelbooru.com][Xml] Parsed page https://gelbooru.com/index.php?page=dapi&s=post&q=index&limit=20&pid=0&tags=baffu: 20 images (20), 0 tags (188), 514 total (514), 26 pages (26)

Since grabbe can see the total, maybe it can store it in the json file for later, and do a comparizon. And warn the user when a monitors sunddently loose a lot of result ? Plus the logic would be that the number increase over time, not decrease, so grabber could catch that something went wrong.

Describe alternatives you've considered

Doing a manual search for the old tag, then finding the new one with an old image id.

Penguin-Guru commented 3 years ago

I haven't used monitors yet but this seems like a good idea to me. Posts may be removed for other reasons so there should be a margin of error to ignore. It might also be worth checking for large increases, perhaps as a percentage increase with an absolute minimum based on a reasonable expectation of uploads within the monitor refresh period. Monitors with suspected errors could probably be highlighted somehow or have an icon button appear next to their entry so it's not too invasive, then logging/alerting could be configured separately.

Seems like we had the same idea for highlighting with colours. :p

Azuriye commented 3 years ago

Definitely a feature worth implementing it for Grabber, like penguin said there might be instances were posts get removed that shouldn't start hammering the user that something's gone wrong with XYZ account. A margin of error will definitely help in this instance. Other then that this feature will definitely help out the user to manage their monitor list in the long run.

Bionus commented 2 years ago

The complexity of this issue is that it needs to keep track of how many images there were over multiple monitorings (or at least some kind of min/max/last) to be able to show the warning.

Keeping only the last count and showing the warning once would be easy technically, but would make it easy to miss, so that's not a good solution.

Keeping it in memory would cause it to show up forever (or until the images come back), which is also an issue, so there would need to be a mechanism to "clear" the warning as a manual action. The user could also delete/recreate the monitor but that's not great UX-wise.

I think the second solution is better it'll need some kind of "clear memory" context menu or similar.