Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.59k stars 220 forks source link

Image viewer button settings not saving between launches on latest nightlies #3110

Closed Wryyyong closed 4 months ago

Wryyyong commented 8 months ago

Bug description

Upon launching an instance of 'Grabber', the program fails to load the values set to activeButtons and allButtons within settings.ini, followed by overwriting the aforementioned settings with @Invalid() values.

This results in the buttons in the viewer being completely absent until you get the program to write fresh values to activeButtons and allButtons (even as little as opening the Options dialog and immediately clicking 'OK' out of it will suffice). Following this, the problem will not occur again until 'Grabber' is closed and re-launched.

This has the added effect of needing to re-create your preferred button settings everytime you wish to use the program.

Steps to reproduce

  1. Launch an instance of 'Grabber' by running its executable.
  2. Run a search with any source(s).
  3. Click on any result to open the image viewer.
  4. Notice the lack of buttons inside of the viewer window.

Expected behavior

'Grabber' loading the values saved to activeButtons and allButtons properly, thus allowing for the user's configuration for the buttons to be saved between program launches.

Context

While I won't upload the full logs and settings here, I will include the portions of both relevant to this issue:

If further information is desired, feel free to ask for it.

System information

RinMaru commented 8 months ago

3071 think this is the same issue?

RinMaru commented 6 months ago

still an issue as of the latest release

Bionus commented 4 months ago

Thanks for the report and the details provided! They actually helped reproduce and pinpoint the root cause of the issue, so I'll be able to provide a fix ASAP 🎉

Closing as duplicate of issue https://github.com/Bionus/imgbrd-grabber/issues/3071 though, since even if this one has more details, that one is older, so I'll move the discussion there 👍