search

Bionus / imgbrd-grabber

Very customizable imageboard/booru downloader with powerful filenaming features.
https://www.bionus.org/imgbrd-grabber/
Apache License 2.0
2.58k stars 220 forks source link

Update ffmpeg.cpp #3233

Closed ProtagNeptune closed 4 months ago

ProtagNeptune commented 4 months ago

libwebp_anim is the encoder for Animated WEBP. -pix_fmt yuva420p is to have image transparency in WEBP.

Bionus commented 4 months ago

Does libwebp_anim also work with static images? For example JPG or PNG to WEBP?

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.63%. Comparing base (3fb1769) to head (bbbe81f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3233 +/- ## ========================================= Coverage 32.63% 32.63% ========================================= Files 384 384 Lines 22355 22355 Branches 3529 3529 ========================================= Hits 7296 7296 - Misses 14942 15058 +116 + Partials 117 1 -116 ```
ProtagNeptune commented 4 months ago

Does libwebp_anim also work with static images? For example JPG or PNG to WEBP?

Yep.

Bionus commented 4 months ago

Indeed, it's confirmed in their mailing list: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2023-August/313001.html

Bionus commented 4 months ago

LGTM! 😄

Bionus commented 4 months ago

Note that the medium-term solution will be to allow users to provide their own CLI arguments for ffmpeg in the conversion options 👍

ProtagNeptune commented 4 months ago

Note that the medium-term solution will be to allow users to provide their own CLI arguments for ffmpeg in the conversion options 👍

There's still no way to separate animated images from static images for conversion purposes thou. This is still needed: https://github.com/Bionus/imgbrd-grabber/issues/3117