BirthdayResearch / defichain-app

DeFi Blockchain desktop app for Windows, Linux and Mac.
https://defichain.com
MIT License
157 stars 57 forks source link

TN: App hangs on reboot due to gen=1 #650

Closed Stonygan closed 3 years ago

Stonygan commented 3 years ago

What happened: Create Masternode in the Testnet with a local Wallet and a AIN on VPS. Createmasternode with GUI with createmasternode OWNER OPERATOR. In the APP the MN are displayd in the section "Mine" and green(online), but described with "local", not remote. VPS works and minted blocks. After a while or maybe after update the VPS to 1.5.2 and restart the worker, the APP displays that the Collateral is not active, State only "Created", before the restart it was ENABLED. Minted Blocks displayed correctly in the wallet.

What you expected to happen:

Status displayed correctly.

How to reproduce it (as minimally and precisely as possible):

Createmasternode with Wallet CLI and remote VPS, restart Node at VPS.

What are your environment parameters?

Anything else we need to know?:

Whats the right way to update the Node on the VPS without get displayproblems in the APP. What happens if iuse the switch "Enable", only recreate defi.conf? Or send some command to the network?

local_offline staking_runs

defichain-bot commented 3 years ago

@Stonygan: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

In the meantime, you can:

  1. Checkout DeFiChain’s Github issue page to see if your issue has already been reported
  2. Submit any logs if you have them, this will greatly expedite the process for us.
  3. You can also join our Telegram or Reddit community channels.
Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/app/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
Stonygan commented 3 years ago

Another behaviour, when you create MN over CLI with seperate Operator MN and then use "Enable" in the GUI, the APP hangs on reboot and cant start anymore. I think its because the Enable switch add gen=1 to config and the whole APP cant start, in the Log is entered:

Unable to stark Blockchain, unknown operator.

Must delete gen=1 manually in the defi.conf that the APP can work again.

izzycsy commented 3 years ago

Hi @Stonygan , thanks for your feedback. Kindly note that when you quit the app, masternode will be auto-disabled and you'll have to re-enable masternode the next time you open the app. To your 2nd comment, please give us time to investigate it.

thedoublejay commented 3 years ago

@Stonygan If GEN and SPV is enabled, it will by default run the masternode. However, if the masternode_operator listed is not owned by your wallet, it will cause some issues on the app. I suggest you check if this masternode_operator is part of your own wallet.

Stonygan commented 3 years ago

Ok, maybe some missunderstanding. I create my MN without the Create-Button, because i want to run the Operator on a seperate Machine (VPS). Therefore i use the CLI and type createmasternode owneradress operatoraddress. The operatoraddress is outside my Wallet and not a part of it. After that, in the GUI the MN appears with the State ENABLED and ONLINE and local. Maybe thats wrong? The Operator is not local. After quitting the APP and start again, the APP displays my Masternode is offline and Status is not enabled. Minting is running fine with this state, but its confusing me and i think other Users, when the APP displays offline and give me the possibility to klick "ENABLE". I know that i not have to use this Button. But others? When i click enable, you are right, defi.conf are rewrite with the options gen and spv. But with this click, APP wants to restart and never come back again, because operator is not in my wallet (and thats correct) I think we must disable the ENABLE Button when Operatornode is remote.

AltCoiFish commented 3 years ago

@Stonygan If GEN and SPV is enabled, it will by default run the masternode. However, if the masternode_operator listed is not owned by your wallet, it will cause some issues on the app. I suggest you check if this masternode_operator is part of your own wallet.

From an end user perspective its already hard enough to setup the MN itself. We should at least update the official tutorial https://defichain.com/learn/run-a-masternode/#for-owners-who-would-like-to-delegate-the-masternode-duties-to-another-node describing the delegation of the MN to a remote VPS. As this seems to not enable the tap on the DFI-Wallet when delegating the operator to a remote VPS.

I suggest you check if this masternode_operator is part of your own wallet.

If I delegate the MN to my operator server, in order to avoid this problem, can I add the operator address to my local wallet?

Another behaviour, when you create MN over CLI with seperate Operator MN and then use "Enable" in the GUI, the APP hangs on reboot and cant start anymore. I think its because the Enable switch add gen=1 to config and the whole APP cant start, in the Log is entered: Unable to stark Blockchain, unknown operator.

We had the same experience when using the cli on the Wallet .

izzycsy commented 3 years ago

Hi @Stonygan , due to priorities for the app, we don't support features that are not through the usual UI route of the app at the moment, I'll be closing this issue in the mean time. Thank you for your understanding! You can post your idea on DeFiChain Discussions, garner some support from the community, and the team can decide whether to implement the feature in the future. Thank you!