search

BirthdayResearch / defichain-app

DeFi Blockchain desktop app for Windows, Linux and Mac.
https://defichain.com
MIT License
157 stars 57 forks source link

Export Button is clickable to early #979

Open MaReCoding opened 3 years ago

MaReCoding commented 3 years ago

Actual behavior:

Whenever I try to export my complete Transaction history from the wallet (including rewards) I got a different result in the exported file. It seems, that the Export-Button can be clicked even if the data in the background is not ready. When I wait to hit the Export button until the cpu load of the defid process goes back, the export is much bigger and contains all reward-transaction.

Expected behavior:

The button should only be clickable, when all data is loaded and ready for the export

How to reproduce it (as minimally and precisely as possible):

  1. Open Wallet
  2. Go to Menu "Transaction"
  3. Hit Export Data
  4. Configure report (Limit: 1000000, Include rewards)
  5. Hit Export as soon as the button is clickable
  6. Go to 3
  7. Configure report (Limit: 1000000, Include rewards)
  8. Wait until the cpu load of defid is very low
  9. Hit Export
  10. Compare exports

What are your environment parameters?

Anything else we need to know?

-I do not use the snapshot. I made a full sync with checkpoints=0 to get the complete tx history

defichain-bot commented 3 years ago

@MaReCoding: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

In the meantime, you can:

  1. Checkout DeFiChain’s Github issue page to see if your issue has already been reported
  2. Submit any logs if you have them, this will greatly expedite the process for us.
  3. You can also join our Telegram or Reddit community channels.
Details I am a bot created to help the [DeFiCh](https://github.com/DeFiCh) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/DeFiCh/app/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [DeFiCh/oss-governance-bot](https://github.com/DeFiCh/oss-governance-bot) repository.
izzycsy commented 3 years ago

Hi @MaReCoding, can you send your logs please? Thank you.

1 App log 2 Compress
MaReCoding commented 3 years ago

Hi @MaReCoding, can you send your logs please? Thank you.

1 App log 2 Compress

Hey @izzycsy, here are the 3 logs

logs.zip

memzila commented 3 years ago

Looks i have the same. I have installed 2.5.2. Will test with waiting until cpu of defid is low. Looks like also a export is running in the background when not anymore needed. Should be possible to cancel it. Or at least see that still something is going on. I have just seen as i have tried to export to whole transaktions and want now to close to app, it doesn't close in timely manner and it looks like defid still is working on exporting, as cpu is still high.

izzycsy commented 3 years ago

Hi @MaReCoding @memzila , thanks, please give us time to investigate.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MaReCoding commented 3 years ago

I don´t understand, why the issue is marked as "stale". The bug is still there...

izzycsy commented 3 years ago

Hi @MaReCoding , yes issue is still persisting, it's just an auto-bot that will turn issues to stale after a period. The team is aware of this issue, however the current prioritisation is on Light Wallet. Thank you for your understanding and patience.

izzycsy commented 3 years ago

Hi @MaReCoding @memzila , update v2.6.0 is out, this is a mandatory update. 
Please read through the release notes before updating. This comment is to notify you about the update.

izzycsy commented 3 years ago

Hi @MaReCoding @memzila , update v2.6.1 is out. 
Please read through the release notes before updating. This comment is to notify you about the update.

izzycsy commented 3 years ago

Hi @MaReCoding @memzila , update v2.6.2 is out. 
Please read through the release notes before updating. This comment is to notify you about the update.

memzila commented 3 years ago

Problem still exist with the newest version

izzycsy commented 2 years ago

Hi @MaReCoding @memzila , update v2.6.3 is out. 
Please read through the release notes before updating. This comment is to notify you about the update.

MartinSeeler commented 2 years ago

Problem still exists for me.

izzycsy commented 2 years ago

Linking another issue to here.

izzycsy commented 2 years ago

Hi @MaReCoding @memzila @MartinSeeler , update v2.7.0 is out, this is a mandatory update. Kindly backup wallet before updating.
 Please read through the release notes before updating. This comment is to notify you about the update.

MartinSeeler commented 2 years ago

This is a really bad bug, since it brings up false / incomplete documents for tax purposes. I really hope this gets fixed in the near future 🙏 , even though you guys are working on all the new stuff coming.

izzycsy commented 2 years ago

Hi @MaReCoding @memzila @MartinSeeler , update v2.7.1 is out, this is a mandatory update. Kindly backup wallet before updating.
 Please read through the release notes before updating. This comment is to notify you about the update.

ab3dat commented 2 years ago

@izzycsy as requested by you, this is the copy of the issue report of issue #1084

Actual behavior: When I try to export the transaction history with option "include rewards" activated, the export also includes the rewards. But as the export fails when trying to export more than 2100000 transactions, I tried to export with value "up to block height" set to 1300000. Even if "include rewards" is set and no matter how I tried to set the values in the dialog ("up to" first, than number of transactions or vice versa or activating the "include rewards" at the beginning or end), the export does not inlcude the rewards.

Expected behavior: Either, it is possible to export more than 2100000 transactions, which may also be a problem of too less memory (export sometimes needs more than 12 GB of RAM) or the exported transaction history covers the rewards too, even if exported from a block somewhere in between.

How to reproduce it (as minimally and precisely as possible): Only the not working way is described here:

  1. Open transaction, wait until loaded
  2. Activate "include rewards" option, wait until loaded
  3. Open "Export wallet data" dialog
  4. Set "up to block height" value to, e.g. 1250000 (or one of the last block height values of the last log file startet from max. block height)
  5. Set number of transactions, wait until export button gets active
  6. Activate option "include rewards" and wait until export button gets activate again (NOTE: this doesn't by far take nearly as long, as if you try to export 2000000 transactions incl. rewards from max. block height)
  7. Click export and save data -> only transcation without rewards are shown

What are your environment parameters? DeFiCh/app Version: 2.7.3 Operating System (OS): Win 10 – RAM (GB): 16 GB – CPU (Intel Core i5/i7/etc.): Core i7 Current free storage capacity: 117 GB

Anything else we need to know? It already worked in the past, I think with version 2.5.x or so

ab3d_logs.zip

dnamurphy commented 2 years ago

I wonder if there's an update on this? It has been reported some 7 months ago, and the issue remains under v. 2.8.4. Whilst I aprreciate a lot of resources have gone into developing the light wallet, many of us (particularly early adopters) are still using the Desktop app, and need reliable access to transaction history.

izzycsy commented 2 years ago

Hi @dnamurphy , unfortunately this is still pending, you'll have to rely on other project such as https://dfi.tax/ , done by the community or get your transaction history from https://defiscan.live/ — paste your address to generate the transactions.

MartinSeeler commented 2 years ago

@izzycsy I've tried to use other tools, e.g. dfi.tax and defi-portfolio. But it looks like there are other problems with old wallets with multiple addresses, where transactions like received rewards can have addresses other than the receiving one. At least for me the problem is, that not all addresses were found and therefore the resulting transactions are not correct. So this is not really an option. Here is the answer from one of the developers of another tool:

The problem with addresses from the "old" DeFiChain-Wallet is, that you can mix the addresses in one transaction. For example: -You have DFI on one address -You have BTC on another address -Now you can add liquidity and tell the wallet to receive rewards on again another address. --> In the export you have now 3 addresses for one transaction. And that means, for the cointracker report, you need all 3 addresses.

And my only hope is now the export functionality of defi wallet itself.

SpecialAgentX commented 2 years ago

Hey, I faced a similar issue by exporting the whole CSV, where lots of tx are missing in output. but now I can reliable reproduce this. I have raised ticket https://github.com/DeFiCh/app/issues/1135 with details.